Add error return values to signatures of public methods to allow migrating to returning errors rather than Fatals in future #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ating to returning errors rather than Fatals in future
MatthewJohn
changed the title
MatthewJohn
requested review from
warrensbox,
yermulnik,
jukie,
MatrixCrawler and
crablab
as code owners
yermulnik
reviewed
Jun 8, 2024
…ser and exit with RC 1
…ot including methods called by the public method)
Use InstallLatestProductVersion, passing in product and handled returned error
MatthewJohn
force-pushed
the
add-error-return-value-public-methods
branch
from
45964d6
to
97c27de
Compare
yermulnik
reviewed
Jun 10, 2024
Co-authored-by: George L. Yermulnik <yz@yz.kiev.ua>
yermulnik
reviewed
Jun 13, 2024
yermulnik
approved these changes
Jun 13, 2024
warrensbox
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See conversation in #452