Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ERRORlog-level #447

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Added ERRORlog-level #447

merged 1 commit into from
Jun 4, 2024

Conversation

MatrixCrawler
Copy link
Collaborator

@MatrixCrawler MatrixCrawler commented Jun 4, 2024 •
edited
Loading

  • added --log-level=ERROR option to supress all non-error logging.

Likely solves #422

image

@MatrixCrawler MatrixCrawler linked an issue Jun 4, 2024 that may be closed by this pull request
How do I turn off logging? #422
Closed
yermulnik
yermulnik reviewed Jun 4, 2024
View reviewed changes
Copy link
Collaborator

@yermulnik yermulnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure we shouldn't be suppressing Errors, Fatals, and Panics.

@MatrixCrawler MatrixCrawler force-pushed the 422-how-do-i-turn-off-logging branch from a159cdb to 4e50312 Compare June 4, 2024 13:32
@MatrixCrawler MatrixCrawler changed the title Added NOLOG log-level Added ERRORlog-level Jun 4, 2024
@MatrixCrawler
Copy link
Collaborator Author

I'm pretty sure we shouldn't be suppressing Errors, Fatals, and Panics.

Right you are. The is not a wise decision. Reverted the changes to introduce an ERROR log level

@MatrixCrawler MatrixCrawler mentioned this pull request Jun 4, 2024
Closed
@MatrixCrawler MatrixCrawler merged commit 9e4aa4f into master Jun 4, 2024
3 checks passed
@MatrixCrawler MatrixCrawler deleted the 422-how-do-i-turn-off-logging branch June 4, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yermulnik yermulnik yermulnik approved these changes

@warrensbox warrensbox Awaiting requested review from warrensbox warrensbox is a code owner

@jukie jukie Awaiting requested review from jukie jukie is a code owner

@crablab crablab Awaiting requested review from crablab crablab is a code owner

@MatthewJohn MatthewJohn Awaiting requested review from MatthewJohn MatthewJohn is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How do I turn off logging?
2 participants
@MatrixCrawler @yermulnik