-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws throttling errors when running awsless list records #144
Comments
Thanks for reporting this bug. Does Do you have an idea of the number of zones and records you have in your infrastructure ? Note also that, for now, the filtering with |
|
OK, according to AWS documentation, we are limited to 5 requests/second for Route53 API, and we are currently making 1 request/zone when listing records. A solution is indeed to provide a way to limit to a zone, with an extra flag or with the existing |
|
I am seeing this problem too and expected there to be a
|
Thanks @macon and @danielhoherd for your outputs. Currently, the filtering on listing (through the Our goal is to fix that by passing down the filtering values down to our AWS fetchers so that we do not fetch unrequested resource and the throttling should diminishes in a lot of cases. This improvement has long been overdue and we deferred it so far in favor of other features and fixes. (Note that all AWS API do not allow filtering on criteria, so we have to approach each of our fetchers starting with those who waste bandwidth.) This week (or next week) I will start to work on that and start with this use case. |
@macon @danielhoherd Fix available on master (if you installed awless with Golang just do a Now the filtering on Also to help, in case of debug, we can use the So basically if any issues give us the output of Let me know how that is going for you so I can close the issue accordingly. Thanks! (This is not the end of our work on throttling ... ;) ) |
@danielhoherd what fix did you have in mind when suggesting the |
@simcap I was thinking of a global API call rate limiter. I'm not positive it's a good idea though, especially since it seems like AWS tolerates different limits for different services. Something similar can be seen in other fetching tools like |
Nice. I'll try it out.
Matt
…On 31 Jan 2018 03:36, "Daniel" ***@***.***> wrote:
@simcap <https://github.com/simcap> I was thinking of a global API call
rate limiter. I'm not positive it's a good idea though, especially since it
seems like AWS tolerates different limits for different services.
Something similar can be seen in other fetching tools like wget and
youtube-dl where requests can be throttled.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#144 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AASMl7deb5cZ_OcgOl2Fbd4Hn09lR8koks5tP9-mgaJpZM4PeIZH>
.
|
@danielhoherd I see. Indeed a flag to control the flow of requests (limiting) is on our list, although we do not want to come to that yet and have other ideas in mind. Anyway @danielhoherd let me know how the records listing is working for you when you have time. Thanks. |
Just tried this out. I'm getting less throttling errors but also the
filtering doesn't seem to work consistently.
For example if I have lots of Names ending in "prod.aws.justgiving" I can
do:
awless list records --filter name=prod.aws.justgiving
And it returns them. In fact I can do:
awless list records --filter name=prod.aws.justgiving | grep branding
I then find my "branding-api.prod.aws.justgiving" Name. But if I do:
awless list records --filter name=branding-api.prod.aws.justgiving
or
awless list records --filter name=branding
I get "No results found."
Regards,
Matt
…On 31 January 2018 at 08:23, Simon Caplette ***@***.***> wrote:
@danielhoherd <https://github.com/danielhoherd> I see. Indeed a flag to
control the flow of requests (limiting) is on our list, although we do not
want to come to that yet and have other ideas in mind.
Anyway @danielhoherd <https://github.com/danielhoherd> let me know how
the records listing is working for you when you have time. Thanks.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#144 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AASMl4L5CJLcbcDTCe4h48F-vR0m5Jooks5tQCMZgaJpZM4PeIZH>
.
|
@macon This is due to the name value for filtering being passed down to the AWS API to filter on the Zone name (here I think this is not good and worse ... not clear for the user, so thanks for reporting it. Ideally, a Zone column should be added in the Records listing so that we could do more clearly I will try to see if I can do that today. |
Hello Simon,
Thanks for the clarification.
Regards,
Matt
…On 2 February 2018 at 09:24, Simon Caplette ***@***.***> wrote:
@macon <https://github.com/macon> This is due to the name value for
filtering being passed down to the AWS API to filter on the *Zone* name
(here prod.aws.justgiving) and *not* the full record name. This is to
accommodate what the AWS APIs provides at the moment.
I think this is not good and worse ... not clear for the user, so thanks
for reporting it.
Ideally, a Zone column should be added in the Records listing so that we
could do more clearly awless ls records --filter zone=... and not get
surprises. We would still be able to filter at the same time on the records
full name with the default local filtering (i.e. once all the results are
fetch). With this fix throttling would not degrade.
I will try to see if I can do that today.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#144 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AASMl9Y7vwxRkPm5IasF7-KqSeOtDg6Qks5tQtQ4gaJpZM4PeIZH>
.
|
Improving on #144 by adding zone in listing records
@macon available on master now:
So it remove the confusion, and you can now basically do: awless list records --filter zone=prod.aws.justgiving ... or more fuzzy matching (i.e. contains substring) awless list records --filter zone=prod (Note throttle has not been degraded (same as with the previous fix) and you can still fuzzy filter by records' name but this will be done locally from all results) |
Awesome stuff Simon. Thanks for quick turn-around.
Regards
Matt
…On 2 February 2018 at 12:44, Simon Caplette ***@***.***> wrote:
@macon <https://github.com/macon> available on master now:
- A new Zone column added when listing records
- --filter zone=... therefore now therefore possible feasible when
listing records
So it remove the confusion, and you can now basically do:
awless list records --filter zone=prod.aws.justgiving
... or more fuzzy matching (i.e. contains substring)
awless list records --filter zone=prod
(Note throttle has not been degraded (same as with the previous fix) and
you can still fuzzy filter by records' name but this will be done locally
from all results)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#144 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AASMl6Hs7QTvA61aCKxXdYeAYHlRH_Psks5tQwM3gaJpZM4PeIZH>
.
|
Get this when running the following
The text was updated successfully, but these errors were encountered: