From 8524c3951fc270f27d5f1eba6c46ba515f9d9128 Mon Sep 17 00:00:00 2001
From: Simon Deziel <simon@sdeziel.info>
Date: Thu, 16 Jun 2022 20:03:03 -0400
Subject: [PATCH] systemd::timer: move variable definition closer to where it's
 used

Signed-off-by: Simon Deziel <simon@sdeziel.info>
---
 manifests/timer.pp | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/manifests/timer.pp b/manifests/timer.pp
index 9dfe809a..ebbb7616 100644
--- a/manifests/timer.pp
+++ b/manifests/timer.pp
@@ -75,13 +75,9 @@
 ) {
   assert_type(Pattern['^.+\.timer$'],$name)
 
-  if $service_unit {
-    $_service_unit = $service_unit
-  } else {
-    $_service_unit = "${basename($name,'.timer')}.service"
-  }
-
   if $service_content or $service_source {
+    $_service_unit = pick($service_unit, "${basename($name,'.timer')}.service")
+
     systemd::unit_file { $_service_unit:
       ensure    => $ensure,
       content   => $service_content,