Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update govmomi to latest #4024

Merged
merged 2 commits into from
Feb 27, 2017
Merged

Update govmomi to latest #4024

merged 2 commits into from
Feb 27, 2017

Conversation

caglar10ur
Copy link
Contributor

Required vmware/govmomi@93064c0

Fixes #3868

Copy link
Member

@dougm dougm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw I had been leaving out govmomi's vendor/go-spew intentionally since we already have it vic/vendor and its only used by govc. But doesn't matter much I suppose.

@caglar10ur
Copy link
Contributor Author

I bumped it using gvt. I can remove the directory manually. Is that how you were doing it or is there another way @dougm ?

@dougm
Copy link
Member

dougm commented Feb 23, 2017

@caglar10ur I use 'gvt update', just didn't stage the govmomi vendor directory when committing. Let's just leave it in there to avoid confusion :) Doesn't hurt to have the 2 copies of go-spew, its small.

@mdubya66
Copy link
Contributor

Lgtm

@caglar10ur caglar10ur merged commit c7b73f1 into vmware:master Feb 27, 2017
@caglar10ur caglar10ur deleted the 3868 branch May 31, 2017 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants