Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added arguments to govc vm.disk.create for thick provisioning and eager scrubbing, as requested in issue #254 #454

Merged
merged 2 commits into from
Mar 8, 2016

Conversation

eyz
Copy link
Contributor

@eyz eyz commented Mar 1, 2016

I hope this is helpful to others who use thick provisioning in their environments

@vmwclabot
Copy link
Member

@eyz, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement.

@dougm
Copy link
Member

dougm commented Mar 7, 2016

Thanks @eyz , change looks good. If you can address the formatting (reported by CI) and the CLA, we can merge this.

@vmwclabot
Copy link
Member

@eyz, VMware has approved your signed contributor license agreement.

@eyz
Copy link
Contributor Author

eyz commented Mar 8, 2016

Formatting resolved. Thank you

dougm added a commit that referenced this pull request Mar 8, 2016
Added arguments to govc vm.disk.create for thick provisioning and eager scrubbing, as requested in issue #254
@dougm dougm merged commit 38bed6b into vmware:master Mar 8, 2016
@dougm
Copy link
Member

dougm commented Mar 8, 2016

👍 thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants