Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add and reorder commits in CHANGELOG #2463

Merged
merged 1 commit into from
May 25, 2021

Conversation

embano1
Copy link
Contributor

@embano1 embano1 commented May 24, 2021

Description

Commit SHAs were missing in the highlight sections. Also, commit SHAs are now left-aligned and tab-separated for a cleaner appearance.

Closes: #2460
Signed-off-by: Michael Gasch mgasch@vmware.com

Example

Release v0.26.0

Release Date: 2021-05-24

💫 govc (CLI)

  • [0e7012d] Add support for getting the VC proxy and no-proxy configuration (#2435)
  • [6afb8ff] Change 'Maintenance Mode' printing in host.info

💫 vcsim (Simulator)

  • [d31941c] Modify Usage of README. (based on v0.25.0)
  • [4fea687] include all namespaces in /about info
  • [bd3467d] avoid edit device panic when DeviceInfo is nil
  • [35a42af] add guest operations process support

🧹 Chore

📖 Commits

  • [a7f2c47] Update vslm types vC build 17986435 (7.0U2HP4)
  • [067374f] Update sms types vC build 17986435 (7.0U2HP4)
  • [d9f507f] Update pbm types vC build 17986435 (7.0U2HP4)

Type of change

Please mark options that are relevant:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Example output generated above with git-chglog

Checklist:

  • My code follows the CONTRIBUTION guidelines of
    this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Closes: vmware#2460
Signed-off-by: Michael Gasch <mgasch@vmware.com>
@embano1
Copy link
Contributor Author

embano1 commented May 24, 2021

@dougm let me know if this is ok and if you want other changes to the template, e.g. not use [] around commit SHAs.

Copy link
Member

@dougm dougm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@embano1 embano1 merged commit c1cddd5 into vmware:master May 25, 2021
@embano1 embano1 deleted the issue-2460 branch May 25, 2021 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add commits to CHANGELOG
3 participants