Ignore AcquireLocalTicket errors #955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradfitz
reviewed
Dec 11, 2017
govc/flags/client.go
Outdated
| return nil, err | ||
| if u.Username() == "" && !c.IsVC() { | ||
| // If no username is provided, try to acquire a local ticket. | ||
| // When invoked remotely, ESX returns an InvalidRequestFault (VC returns NotSupportedFault). |
There was a problem hiding this comment.
this parenthetical is slightly confusing considering the conditional on line 431 excludes this path for VC.
elaborate or remove?
There was a problem hiding this comment.
Removed. Thanks for reviewing Brad!
|
Code LGTM. Thanks for the fix! |
If no username is provided, the govc client tries to acquire a local ticket. When invoked remotely, ESX returns an InvalidRequestFault (VC returns NotSupportedFault). So, rather than return an error here, fallthrough to Login() with the original User to to avoid what would be a confusing error message. Don't try AcquireLocalTicket at all against vCenter as it is unsupported. Fixes vmware#952
anfernee
reviewed
Dec 11, 2017
| // If no username is provided, try to acquire a local ticket. | ||
| // When invoked remotely, ESX returns an InvalidRequestFault. | ||
| // So, rather than return an error here, fallthrough to Login() with the original User to | ||
| // to avoid what would be a confusing error message. |
There was a problem hiding this comment.
so when error happens here, we login with empty user, and get something like LoginFault, which is less confusing. Is that accurate?
There was a problem hiding this comment.
exactly, InvalidLoginFault with the appropriate localized message.
anfernee
approved these changes
Dec 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If no username is provided, the govc client tries to acquire a local ticket.
When invoked remotely, ESX returns an InvalidRequestFault (VC returns NotSupportedFault).
So, rather than return an error here, fallthrough to Login() with the original User to
to avoid what would be a confusing error message.
Don't try AcquireLocalTicket at all against vCenter as it is unsupported.
Fixes #952