Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add govc-executable-name customization option #645

Merged
merged 1 commit into from
Dec 13, 2016
Merged

Conversation

tzz
Copy link
Contributor

@tzz tzz commented Dec 13, 2016

@dougm I hope this is useful. I needed it because my gopath is (intentionally) not part of my exec-path.

@vmwclabot
Copy link
Member

@tzz, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

@dougm
Copy link
Member

dougm commented Dec 13, 2016

@tzz looks good, happy to add this. Wondering though, should we name this variable govc-command as that seems to be the convention (diff-command, grep-command, etc). We could also rename the existing govc-command function to govc-format to avoid any confusion.

@tzz
Copy link
Contributor Author

tzz commented Dec 13, 2016

That's exactly why I avoided govc-command ha ha. I did as you suggested, renaming the function govc-command to govc-format-command and creating the new defcustom. Change force-pushed.

@dougm dougm merged commit ca99f8d into vmware:master Dec 13, 2016
@dougm
Copy link
Member

dougm commented Dec 13, 2016

thanks @tzz !

@vmwclabot
Copy link
Member

@tzz, VMware has approved your signed contributor license agreement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants