Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update integrated Restic version and add insecureSkipTLSVerify for Restic CLI #4820

Closed
blackpiglet opened this issue Apr 11, 2022 · 2 comments · Fixed by #4839
Closed

Update integrated Restic version and add insecureSkipTLSVerify for Restic CLI #4820

blackpiglet opened this issue Apr 11, 2022 · 2 comments · Fixed by #4839
Assignees
Labels
kind/requirement Restic Relates to the restic integration
Milestone

Comments

@blackpiglet
Copy link
Contributor

Describe the problem/challenge you have
[A description of the current limitation/problem/challenge that you are experiencing.]
There are some cases that Velero communicate with a TLS enabled object store, but the use has no valid CA.
By far, Velero can set insecureSkipTLSVerify flag in BSL configuration to let object plugin to skip TLS verification, but this is not possible for Velero Restic sub-command yet.

Describe the solution you'd like
[A clear and concise description of what you want to happen.]
Restic v0.13 already support skip TLS in command line parameter, so update integrated Restic version and add insecureSkipTLSVerify for Velero Restic sub-command to support this function.

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Environment:

  • Velero version (use velero version): v1.8
  • Kubernetes version (use kubectl version): v1.22
  • Kubernetes installer & version: vSphere
  • Cloud provider or hardware configuration: vSphere
  • OS (e.g. from /etc/os-release): Ubuntu

Vote on this issue!

This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here.
Use the "reaction smiley face" up to the right of this comment to vote.

  • 👍 for "The project would be better with this feature added"
  • 👎 for "This feature will not enhance the project in a meaningful way"
@blackpiglet blackpiglet added the Restic Relates to the restic integration label Apr 11, 2022
@blackpiglet blackpiglet self-assigned this Apr 11, 2022
@blackpiglet
Copy link
Contributor Author

Restic's PR adding insecureSkipTLSVerify support is: restic/restic#2657

blackpiglet pushed a commit to blackpiglet/velero that referenced this issue Apr 11, 2022
…stic CLI

Fix: vmware-tanzu#4820

Signed-off-by: Xun Jiang <jxun@vmware.com>
blackpiglet pushed a commit to blackpiglet/velero that referenced this issue Apr 11, 2022
…stic CLI

Fix: vmware-tanzu#4820

Signed-off-by: Xun Jiang <jxun@vmware.com>
@blackpiglet
Copy link
Contributor Author

Due to Restic version upgrade, some CVE issues reported about Restic binary are also fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment