This repository has been archived by the owner on Jul 15, 2021. It is now read-only.
Kubeconfig download #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 13, 2018 14:32
Signed-off-by: Jim Weber <jim@heptio.com>
Signed-off-by: Jim Weber <jim@heptio.com>
Signed-off-by: Jim Weber <jim@heptio.com>
mauilion
suggested changes
Jul 12, 2018
templates/kubeconfig.tmpl
Outdated
| apiVersion: v1 | ||
| clusters: | ||
| - cluster: | ||
| certificate-authority: <PATH TO CA File> |
There was a problem hiding this comment.
Can you update this to base64 encode and embed this cert?
It would look like:
- cluster:
certificate-authority-data: LS0tLS1CRUdJTiBDRVJUSUZJQ0FURS0tLS0tCk1JSUM1ekNDQWMrZ0F3SUJBZ0lCQVRBTkJna3Foa2lHOXcwQkFRc0ZBREFWTVJNd0VRWURWUVFERXdwdGFXNXAKYTNWaVpVTkJNQjRYRFRFNE1ETXlPVEU1TURnd09Wb1hEVEk0TURNeU5qRTVNRGd3T1Zvd0ZURVRNQkVHQTFVRQpBeE1LYldsdWFXdDFZbVZEUVRDQ0FTSXdEUVlKS29aSWh2Y05BUUVCQlFBRGdnRVBBRENDQVFvQ2dnRUJBTHdHCkZySzZaZ3pBTVB0bGpOdVJZeWRmczhrRlF5Y1poTmV3UUF1NCtYV1dSOW1WM0wvMnBVS0pYbWMzdTQ1L1pkK2gKd2VRTUlFR0Z6LzVqalpVU0J4UjNVdTc3WlhFWWVRdEExU24rc2ZBVldKZ1FqNjFLQjdrdndLZ2xYY1E5QUlQYgpaYlZUa0pmWFEyeTA4YmhPck90eERkdExOeXhqbWhiY3g3UDl2SGRUMkxsMHVNaWpaVkRkaEJ5Q2FFY0Erdnl6Ckd2cDVjYmd5RjBWY2VvU3JTMmlEcnNyL1c3dXdaSWpYbGJoUitQNXBRZXVIc2dOQ1U3QXlyV3hPV1NwOGxlT2QKQ1VpeGxzNmpNdW4vZzFzSGVBS3Z6Vkl2REFROW9KcFNGU2wraC9KTnRWZFpBdlNYRkpNbmxKTGxIMWpOU0pSVgo4cFd3VGVlNDBOc0sxcjdmbG5NQ0F3RUFBYU5DTUVBd0RnWURWUjBQQVFIL0JBUURBZ0trTUIwR0ExVWRKUVFXCk1CUUdDQ3NHQVFVRkJ3TUNCZ2dyQmdFRkJRY0RBVEFQQmdOVkhSTUJBZjhFQlRBREFRSC9NQTBHQ1NxR1NJYjMKRFFFQkN3VUFBNElCQVFDNTY5cVh0R2s5UldkV09zQ3BjZnlmdTZBK0oyZVgvVDViRFQvS1RJaXVSVnNrbnpyUgpCWktjUG9UWWFxdmNMQVlONXMxSkVtbmJEanZ2WDZuM0R1NGtvUTkwUDNTT3BXbng2bFZZRzFPMUt1YzhEaEZCClhTZ0JNSkhFWkVVVm0yYlB1TEZ0RTdxcXZMQlJBZGFxSVhKUTRRcm9sM20wVGprT1BQUU1aNE5ZK294Um1ZK1QKZ3UzZEZRUnFDcVR4WUZuR2dzSHR4QjB2bkpVMTVhWmNqYytrZnA3RnB0OWZiNzg5Y1BXM0JqNWdBaURzZ2dMKwpDNnBJMVIwMXlqSUpPRU1kL3BGZTN5VHZJYTFjdDdyNklqenpvSmRRYVlSTmtXd0YzLzVxeTk2cDNNRDhVK05VCmFWek5pTW9RL0NaYVpnWHJhVm4rQ2VTblhDd0pyYis2eWRPZQotLS0tLUVORCBDRVJUSUZJQ0FURS0tLS0tCg==
jpweber
force-pushed
the
kubeconfig-download
branch
from
58bbf16
to
4e1e7d1
Compare
commit 599eec3 Author: Joe Rocklin <joe.rocklin@gmail.com> Date: Fri Jul 20 13:50:25 2018 -0400 put the base64 encoded CA file into the kubeconfig file Signed-off-by: Joe Rocklin <joe.rocklin@gmail.com> commit c3495a7 Merge: 4e1e7d1 70325f5 Author: Joe Rocklin <joe.rocklin@gmail.com> Date: Fri Jul 20 15:26:39 2018 -0400 Merge branch 'master' into kubeconfig-download Signed-off-by: Joe Rocklin <joe.rocklin@gmail.com> commit 70325f5 Author: Duffie Cooley <dcooley@heptio.com> Date: Tue Jul 17 05:50:17 2018 -0700 update README.md to reflect mjibson/esc (vmware-archive#40) Signed-off-by: Duffie Cooley <dcooley@heptio.com> commit 4bcf044 Author: Duffie Cooley <dcooley@heptio.com> Date: Fri Jul 13 09:17:39 2018 -0700 Replace go-bindata with github.com/mjibson/esc (vmware-archive#39) - Updated the Makefile to use esc. - Modified handlers.go to use FSString instead of Assets. - Fixed up the tests so that they pass. Signed-off-by: Duffie Cooley <dcooley@heptio.com> commit c64bfe5 Author: Alexander Brand <alexbrand09@gmail.com> Date: Mon Jul 9 22:06:31 2018 -0400 cmd/gangway: validate that API server URL is set in the config (vmware-archive#37) Signed-off-by: Alexander Brand <alexbrand09@gmail.com> commit 7207ee1 Author: Craig Tracey <craigtracey@gmail.com> Date: Fri Jun 15 13:07:53 2018 -0400 Bump manifest version to v2.0.0 (vmware-archive#35) Signed-off-by: Craig Tracey <craigtracey@gmail.com> commit 97b806c Author: Joe Beda <joe@heptio.com> Date: Fri Jun 15 10:02:47 2018 -0700 Fix tests (vmware-archive#34) Signed-off-by: Joe Beda <joe.github@bedafamily.com> commit de8db1e Author: Joe Beda <joe@heptio.com> Date: Thu Jun 14 18:15:27 2018 -0700 Introduce session key (vmware-archive#33) Signed-off-by: Joe Beda <joe.github@bedafamily.com> commit ca743b9 Author: Joe Beda <joe@heptio.com> Date: Thu Jun 14 11:40:39 2018 -0700 Update docs (vmware-archive#32) * update bindata * Rework docs for more commonality and room to add more details. Signed-off-by: Joe Beda <joe.github@bedafamily.com> commit eea76b9 Author: Carl Danley <carldanley@gmail.com> Date: Wed Jun 13 18:37:00 2018 -0400 Added TLS support for gangway (vmware-archive#27) * Added TLS serving support for gangway Signed-off-by: carldanley <carldanley@gmail.com> * Changes to simplify TLS checking & loading Signed-off-by: carldanley <carldanley@gmail.com> * Ripped out the file-checking portion of TLS After discussing this with @craigtracey, we thought this is the best way forward. Signed-off-by: carldanley <carldanley@gmail.com> Signed-off-by: Jim Weber <jim@heptio.com>
Signed-off-by: Jim Weber <jim@heptio.com>
jpweber
force-pushed
the
kubeconfig-download
branch
from
d0c670c
to
04351c2
Compare
|
Ok got this all fixed up now @mauilion. thanks @joerocklin for the PR to help this PR along, I appreciate it. |
|
Hey @jpweber, I'm seeing build errors with this PR, could you take a look? Also, will probably need another rebase as well. cmd/gangway/handlers.go:77:22: undefined: kubeConfigFile
cmd/gangway/handlers.go:269:23: undefined: kubeConfigFile |
|
Ok I’ll take a look. I may not be able to get to it until next week because of travel this week |
added 2 commits
October 1, 2018 12:04
Signed-off-by: Jim Weber <jim@heptio.com>
Signed-off-by: Jim Weber <jim@heptio.com>
jpweber
force-pushed
the
kubeconfig-download
branch
from
26df706
to
0e70fc2
Compare
…config-download Signed-off-by: Jim Weber <jpweber@gmail.com> # Conflicts: # cmd/gangway/bindata.go
Signed-off-by: Jim Weber <jpweber@gmail.com>
|
@stevesloka ok got everything update to date with no conflicts. |
stevesloka
reviewed
Oct 1, 2018
Signed-off-by: Jim Weber <jpweber@gmail.com>
|
/lgtm |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Command line page now generates a kubeconfig and there is a button in the bottom right to download the config as an option rather than generating your own with copying commands