Skip to content

Commit

Permalink
feat(build): warn dynamic import module with a static import alongside (
Browse files Browse the repository at this point in the history
  • Loading branch information
fi3ework authored Jun 10, 2023
1 parent ff3ce31 commit 127c334
Show file tree
Hide file tree
Showing 2 changed files with 48 additions and 1 deletion.
30 changes: 29 additions & 1 deletion packages/vite/src/node/plugins/reporter.ts
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,35 @@ export function buildReporterPlugin(config: ResolvedConfig): Plugin {
compressedCount = 0
},

renderChunk() {
renderChunk(code, chunk) {
for (const id of chunk.moduleIds) {
const module = this.getModuleInfo(id)
if (!module) continue
// When a dynamic importer shares a chunk with the imported module,
// warn that the dynamic imported module will not be moved to another chunk (#12850).
if (module.importers.length && module.dynamicImporters.length) {
// Filter out the intersection of dynamic importers and sibling modules in
// the same chunk. The intersecting dynamic importers' dynamic import is not
// expected to work. Note we're only detecting the direct ineffective
// dynamic import here.
if (
module.dynamicImporters.some((m) => chunk.moduleIds.includes(m))
) {
this.warn(
`\n(!) ${
module.id
} is dynamically imported by ${module.dynamicImporters
.map((m) => m)
.join(', ')} but also statically imported by ${module.importers
.map((m) => m)
.join(
', ',
)}, dynamic import will not move module into another chunk.\n`,
)
}
}
}

chunkCount++
if (shouldLogInfo) {
if (!tty) {
Expand Down
19 changes: 19 additions & 0 deletions playground/dynamic-import/__tests__/dynamic-import.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -129,3 +129,22 @@ test('should work with load ../ and contain itself directory', async () => {
true,
)
})

test.runIf(isBuild)(
'should rollup warn when static and dynamic import a module in same chunk',
async () => {
const log = serverLogs.join('\n')
expect(log).toContain(
'dynamic import will not move module into another chunk',
)
expect(log).toMatch(
/\(!\).*\/dynamic-import\/files\/mxd\.js is dynamically imported by/,
)
expect(log).toMatch(
/\(!\).*\/dynamic-import\/files\/mxd\.json is dynamically imported by/,
)
expect(log).not.toMatch(
/\(!\).*\/dynamic-import\/nested\/shared\.js is dynamically imported by/,
)
},
)

0 comments on commit 127c334

Please sign in to comment.