From 12e32f53470098e14996730fa7fe9165159419d6 Mon Sep 17 00:00:00 2001 From: Laurent Goujon Date: Mon, 10 Jun 2024 17:40:54 -0700 Subject: [PATCH] GH-40830: [Java] Adding Spotless to Performance module (#42057) ### Rationale for this change Applying Java code style and formatting options to Performance module. ### What changes are included in this PR? Java code formatting via spotless plugin has been enabled. ### Are these changes tested? Yes, but doesn't involve test cases, the plugin itself corrects. ### Are there any user-facing changes? No * GitHub Issue: #40830 Authored-by: Laurent Goujon Signed-off-by: David Li --- java/performance/pom.xml | 2 + .../arrow/adapter/AvroAdapterBenchmarks.java | 47 ++++++++------- .../adapter/jdbc/JdbcAdapterBenchmarks.java | 45 +++++++------- .../search/ParallelSearcherBenchmarks.java | 13 ++-- .../arrow/memory/AllocatorBenchmarks.java | 24 +++----- .../arrow/memory/ArrowBufBenchmarks.java | 20 ++----- .../util/ArrowBufPointerBenchmarks.java | 19 ++---- .../util/ByteFunctionHelpersBenchmarks.java | 38 +++++++----- .../vector/BaseValueVectorBenchmarks.java | 28 ++++----- .../vector/BitVectorHelperBenchmarks.java | 59 +++++++------------ .../arrow/vector/DecimalVectorBenchmarks.java | 33 ++++------- .../apache/arrow/vector/Float8Benchmarks.java | 31 ++++------ .../arrow/vector/FloatingPointBenchmarks.java | 20 ++----- .../apache/arrow/vector/IntBenchmarks.java | 14 ++--- .../arrow/vector/VarCharBenchmarks.java | 22 ++----- .../vector/VariableWidthVectorBenchmarks.java | 21 +++---- .../arrow/vector/VectorLoaderBenchmark.java | 24 ++------ .../arrow/vector/VectorUnloaderBenchmark.java | 19 ++---- .../DictionaryEncoderBenchmarks.java | 29 ++++----- .../vector/ipc/WriteChannelBenchmark.java | 16 ++--- .../message/ArrowRecordBatchBenchmarks.java | 22 +++---- .../vector/util/TransferPairBenchmarks.java | 22 ++----- 22 files changed, 205 insertions(+), 363 deletions(-) diff --git a/java/performance/pom.xml b/java/performance/pom.xml index 83b0a88da063b..1db900c81e912 100644 --- a/java/performance/pom.xml +++ b/java/performance/pom.xml @@ -30,6 +30,8 @@ under the License. JMH Performance benchmarks for other Arrow libraries. + dev/checkstyle/checkstyle-spotless.xml + none 1.37 benchmarks true diff --git a/java/performance/src/main/java/org/apache/arrow/adapter/AvroAdapterBenchmarks.java b/java/performance/src/main/java/org/apache/arrow/adapter/AvroAdapterBenchmarks.java index c07aeffafb10c..6032a79ecec77 100644 --- a/java/performance/src/main/java/org/apache/arrow/adapter/AvroAdapterBenchmarks.java +++ b/java/performance/src/main/java/org/apache/arrow/adapter/AvroAdapterBenchmarks.java @@ -14,13 +14,11 @@ * See the License for the specific language governing permissions and * limitations under the License. */ - package org.apache.arrow.adapter; import java.io.ByteArrayInputStream; import java.io.ByteArrayOutputStream; import java.util.concurrent.TimeUnit; - import org.apache.arrow.adapter.avro.AvroToArrow; import org.apache.arrow.adapter.avro.AvroToArrowConfig; import org.apache.arrow.adapter.avro.AvroToArrowConfigBuilder; @@ -52,9 +50,7 @@ import org.openjdk.jmh.runner.options.Options; import org.openjdk.jmh.runner.options.OptionsBuilder; -/** - * Benchmarks for avro adapter. - */ +/** Benchmarks for avro adapter. */ @State(Scope.Benchmark) public class AvroAdapterBenchmarks { @@ -65,21 +61,25 @@ public class AvroAdapterBenchmarks { private Schema schema; private BinaryDecoder decoder; - /** - * Setup benchmarks. - */ + /** Setup benchmarks. */ @Setup public void prepare() throws Exception { BufferAllocator allocator = new RootAllocator(Integer.MAX_VALUE); config = new AvroToArrowConfigBuilder(allocator).build(); - String schemaStr = "{\n" + " \"namespace\": \"org.apache.arrow.avro\",\n" + - " \"type\": \"record\",\n" + " \"name\": \"testBenchmark\",\n" + " \"fields\": [\n" + - " {\"name\": \"f0\", \"type\": \"string\"},\n" + - " {\"name\": \"f1\", \"type\": \"int\"},\n" + - " {\"name\": \"f2\", \"type\": \"long\"},\n" + - " {\"name\": \"f3\", \"type\": \"boolean\"},\n" + - " {\"name\": \"f4\", \"type\": \"float\"}\n" + " ]\n" + "}"; + String schemaStr = + "{\n" + + " \"namespace\": \"org.apache.arrow.avro\",\n" + + " \"type\": \"record\",\n" + + " \"name\": \"testBenchmark\",\n" + + " \"fields\": [\n" + + " {\"name\": \"f0\", \"type\": \"string\"},\n" + + " {\"name\": \"f1\", \"type\": \"int\"},\n" + + " {\"name\": \"f2\", \"type\": \"long\"},\n" + + " {\"name\": \"f3\", \"type\": \"boolean\"},\n" + + " {\"name\": \"f4\", \"type\": \"float\"}\n" + + " ]\n" + + "}"; schema = new Schema.Parser().parse(schemaStr); ByteArrayOutputStream out = new ByteArrayOutputStream(); @@ -96,12 +96,11 @@ public void prepare() throws Exception { writer.write(record, encoder); } - decoder = new DecoderFactory().directBinaryDecoder(new ByteArrayInputStream(out.toByteArray()), null); + decoder = + new DecoderFactory().directBinaryDecoder(new ByteArrayInputStream(out.toByteArray()), null); } - /** - * Tear down benchmarks. - */ + /** Tear down benchmarks. */ @TearDown public void tearDown() { config.getAllocator().close(); @@ -109,6 +108,7 @@ public void tearDown() { /** * Test {@link AvroToArrow#avroToArrowIterator(Schema, Decoder, AvroToArrowConfig)}. + * * @return useless. To avoid DCE by JIT. */ @Benchmark @@ -117,7 +117,8 @@ public void tearDown() { public int testAvroToArrow() throws Exception { decoder.inputStream().reset(); int sum = 0; - try (AvroToArrowVectorIterator iter = AvroToArrow.avroToArrowIterator(schema, decoder, config)) { + try (AvroToArrowVectorIterator iter = + AvroToArrow.avroToArrowIterator(schema, decoder, config)) { while (iter.hasNext()) { VectorSchemaRoot root = iter.next(); IntVector intVector = (IntVector) root.getVector("f1"); @@ -131,10 +132,8 @@ public int testAvroToArrow() throws Exception { } public static void main(String[] args) throws RunnerException { - Options opt = new OptionsBuilder() - .include(AvroAdapterBenchmarks.class.getSimpleName()) - .forks(1) - .build(); + Options opt = + new OptionsBuilder().include(AvroAdapterBenchmarks.class.getSimpleName()).forks(1).build(); new Runner(opt).run(); } diff --git a/java/performance/src/main/java/org/apache/arrow/adapter/jdbc/JdbcAdapterBenchmarks.java b/java/performance/src/main/java/org/apache/arrow/adapter/jdbc/JdbcAdapterBenchmarks.java index f6dab83b7cd0c..a2eb9674e4d37 100644 --- a/java/performance/src/main/java/org/apache/arrow/adapter/jdbc/JdbcAdapterBenchmarks.java +++ b/java/performance/src/main/java/org/apache/arrow/adapter/jdbc/JdbcAdapterBenchmarks.java @@ -14,7 +14,6 @@ * See the License for the specific language governing permissions and * limitations under the License. */ - package org.apache.arrow.adapter.jdbc; import java.sql.Connection; @@ -23,7 +22,6 @@ import java.sql.ResultSet; import java.sql.Statement; import java.util.concurrent.TimeUnit; - import org.apache.arrow.adapter.jdbc.consumer.BigIntConsumer; import org.apache.arrow.adapter.jdbc.consumer.BitConsumer; import org.apache.arrow.adapter.jdbc.consumer.IntConsumer; @@ -50,27 +48,23 @@ import org.openjdk.jmh.runner.options.Options; import org.openjdk.jmh.runner.options.OptionsBuilder; -/** - * Benchmarks for Jdbc adapter. - */ +/** Benchmarks for Jdbc adapter. */ public class JdbcAdapterBenchmarks { // checkstyle:off: MissingJavadocMethod private static final int VALUE_COUNT = 3000; private static final String CREATE_STATEMENT = - "CREATE TABLE test_table (f0 INT, f1 LONG, f2 VARCHAR, f3 BOOLEAN);"; + "CREATE TABLE test_table (f0 INT, f1 LONG, f2 VARCHAR, f3 BOOLEAN);"; private static final String INSERT_STATEMENT = - "INSERT INTO test_table (f0, f1, f2, f3) VALUES (?, ?, ?, ?);"; + "INSERT INTO test_table (f0, f1, f2, f3) VALUES (?, ?, ?, ?);"; private static final String QUERY = "SELECT f0, f1, f2, f3 FROM test_table;"; private static final String DROP_STATEMENT = "DROP TABLE test_table;"; private static final String URL = "jdbc:h2:mem:JdbcAdapterBenchmarks"; private static final String DRIVER = "org.h2.Driver"; - /** - * State object for the jdbc e2e benchmark. - */ + /** State object for the jdbc e2e benchmark. */ @State(Scope.Benchmark) public static class JdbcState { @@ -87,7 +81,8 @@ public static class JdbcState { @Setup(Level.Trial) public void prepareState() throws Exception { allocator = new RootAllocator(Integer.MAX_VALUE); - config = new JdbcToArrowConfigBuilder().setAllocator(allocator).setTargetBatchSize(1024).build(); + config = + new JdbcToArrowConfigBuilder().setAllocator(allocator).setTargetBatchSize(1024).build(); Class.forName(DRIVER); conn = DriverManager.getConnection(URL); @@ -129,9 +124,7 @@ public void tearDownState() throws Exception { } } - /** - * State object for the consume benchmark. - */ + /** State object for the consume benchmark. */ @State(Scope.Benchmark) public static class ConsumeState { @@ -166,7 +159,8 @@ public static class ConsumeState { @Setup(Level.Trial) public void prepare() throws Exception { allocator = new RootAllocator(Integer.MAX_VALUE); - config = new JdbcToArrowConfigBuilder().setAllocator(allocator).setTargetBatchSize(1024).build(); + config = + new JdbcToArrowConfigBuilder().setAllocator(allocator).setTargetBatchSize(1024).build(); Class.forName(DRIVER); conn = DriverManager.getConnection(URL); @@ -233,9 +227,7 @@ public void tearDown() throws Exception { } } - /** - * State object for the jdbc row consume benchmark. - */ + /** State object for the jdbc row consume benchmark. */ @State(Scope.Benchmark) public static class RowConsumeState { @@ -256,7 +248,11 @@ public static class RowConsumeState { @Setup(Level.Trial) public void prepareState() throws Exception { allocator = new RootAllocator(Integer.MAX_VALUE); - config = new JdbcToArrowConfigBuilder().setAllocator(allocator).setTargetBatchSize(VALUE_COUNT).build(); + config = + new JdbcToArrowConfigBuilder() + .setAllocator(allocator) + .setTargetBatchSize(VALUE_COUNT) + .build(); Class.forName(DRIVER); conn = DriverManager.getConnection(URL); @@ -305,6 +301,7 @@ public void tearDownState() throws Exception { /** * Test {@link JdbcToArrow#sqlToArrowVectorIterator(ResultSet, JdbcToArrowConfig)}. + * * @return useless. To avoid DCE by JIT. */ @Benchmark @@ -312,7 +309,8 @@ public void tearDownState() throws Exception { @OutputTimeUnit(TimeUnit.MICROSECONDS) public int testJdbcToArrow(JdbcState state) throws Exception { int valueCount = 0; - try (ArrowVectorIterator iter = JdbcToArrow.sqlToArrowVectorIterator(state.resultSet, state.config)) { + try (ArrowVectorIterator iter = + JdbcToArrow.sqlToArrowVectorIterator(state.resultSet, state.config)) { while (iter.hasNext()) { VectorSchemaRoot root = iter.next(); IntVector intVector = (IntVector) root.getFieldVectors().get(0); @@ -349,13 +347,10 @@ public void consumeRowsBenchmark(RowConsumeState state) throws Exception { } public static void main(String[] args) throws RunnerException { - Options opt = new OptionsBuilder() - .include(JdbcAdapterBenchmarks.class.getSimpleName()) - .forks(1) - .build(); + Options opt = + new OptionsBuilder().include(JdbcAdapterBenchmarks.class.getSimpleName()).forks(1).build(); new Runner(opt).run(); } // checkstyle:on: MissingJavadocMethod } - diff --git a/java/performance/src/main/java/org/apache/arrow/algorithm/search/ParallelSearcherBenchmarks.java b/java/performance/src/main/java/org/apache/arrow/algorithm/search/ParallelSearcherBenchmarks.java index c9fc5cc4bef9c..83d555560d372 100644 --- a/java/performance/src/main/java/org/apache/arrow/algorithm/search/ParallelSearcherBenchmarks.java +++ b/java/performance/src/main/java/org/apache/arrow/algorithm/search/ParallelSearcherBenchmarks.java @@ -14,13 +14,11 @@ * See the License for the specific language governing permissions and * limitations under the License. */ - package org.apache.arrow.algorithm.search; import java.util.concurrent.ExecutorService; import java.util.concurrent.Executors; import java.util.concurrent.TimeUnit; - import org.apache.arrow.memory.BufferAllocator; import org.apache.arrow.memory.RootAllocator; import org.apache.arrow.vector.IntVector; @@ -39,17 +37,13 @@ import org.openjdk.jmh.runner.options.Options; import org.openjdk.jmh.runner.options.OptionsBuilder; -/** - * Benchmarks for {@link ParallelSearcher}. - */ +/** Benchmarks for {@link ParallelSearcher}. */ public class ParallelSearcherBenchmarks { // checkstyle:off: MissingJavadocMethod private static final int VECTOR_LENGTH = 1024 * 1024; - /** - * State object for the benchmarks. - */ + /** State object for the benchmarks. */ @State(Scope.Benchmark) public static class SearchState { @@ -106,7 +100,8 @@ public void searchBenchmark(SearchState state) throws Exception { } public static void main(String[] args) throws RunnerException { - Options opt = new OptionsBuilder() + Options opt = + new OptionsBuilder() .include(ParallelSearcherBenchmarks.class.getSimpleName()) .forks(1) .build(); diff --git a/java/performance/src/main/java/org/apache/arrow/memory/AllocatorBenchmarks.java b/java/performance/src/main/java/org/apache/arrow/memory/AllocatorBenchmarks.java index 88fcf73f0303b..f275090aae6bf 100644 --- a/java/performance/src/main/java/org/apache/arrow/memory/AllocatorBenchmarks.java +++ b/java/performance/src/main/java/org/apache/arrow/memory/AllocatorBenchmarks.java @@ -14,12 +14,9 @@ * See the License for the specific language governing permissions and * limitations under the License. */ - package org.apache.arrow.memory; import java.util.concurrent.TimeUnit; - -import org.apache.arrow.memory.ArrowBuf; import org.apache.arrow.memory.rounding.RoundingPolicy; import org.apache.arrow.memory.rounding.SegmentRoundingPolicy; import org.openjdk.jmh.annotations.Benchmark; @@ -31,14 +28,10 @@ import org.openjdk.jmh.runner.options.Options; import org.openjdk.jmh.runner.options.OptionsBuilder; -/** - * Benchmarks for allocators. - */ +/** Benchmarks for allocators. */ public class AllocatorBenchmarks { - /** - * Benchmark for the default allocator. - */ + /** Benchmark for the default allocator. */ @Benchmark @BenchmarkMode(Mode.AverageTime) @OutputTimeUnit(TimeUnit.MICROSECONDS) @@ -59,9 +52,7 @@ public void defaultAllocatorBenchmark() { } } - /** - * Benchmark for allocator with segment rounding policy. - */ + /** Benchmark for allocator with segment rounding policy. */ @Benchmark @BenchmarkMode(Mode.AverageTime) @OutputTimeUnit(TimeUnit.MICROSECONDS) @@ -71,7 +62,8 @@ public void segmentRoundingPolicyBenchmark() { final int segmentSize = 1024; RoundingPolicy policy = new SegmentRoundingPolicy(segmentSize); - try (RootAllocator allocator = new RootAllocator(AllocationListener.NOOP, bufferSize * numBuffers, policy)) { + try (RootAllocator allocator = + new RootAllocator(AllocationListener.NOOP, bufferSize * numBuffers, policy)) { ArrowBuf[] buffers = new ArrowBuf[numBuffers]; for (int i = 0; i < numBuffers; i++) { @@ -85,10 +77,8 @@ public void segmentRoundingPolicyBenchmark() { } public static void main(String[] args) throws RunnerException { - Options opt = new OptionsBuilder() - .include(AllocatorBenchmarks.class.getSimpleName()) - .forks(1) - .build(); + Options opt = + new OptionsBuilder().include(AllocatorBenchmarks.class.getSimpleName()).forks(1).build(); new Runner(opt).run(); } diff --git a/java/performance/src/main/java/org/apache/arrow/memory/ArrowBufBenchmarks.java b/java/performance/src/main/java/org/apache/arrow/memory/ArrowBufBenchmarks.java index ef4da582829bd..8aaee28e77417 100644 --- a/java/performance/src/main/java/org/apache/arrow/memory/ArrowBufBenchmarks.java +++ b/java/performance/src/main/java/org/apache/arrow/memory/ArrowBufBenchmarks.java @@ -14,11 +14,9 @@ * See the License for the specific language governing permissions and * limitations under the License. */ - package org.apache.arrow.memory; import java.util.concurrent.TimeUnit; - import org.openjdk.jmh.annotations.Benchmark; import org.openjdk.jmh.annotations.BenchmarkMode; import org.openjdk.jmh.annotations.Mode; @@ -32,9 +30,7 @@ import org.openjdk.jmh.runner.options.Options; import org.openjdk.jmh.runner.options.OptionsBuilder; -/** - * Benchmarks for {@link ArrowBuf}. - */ +/** Benchmarks for {@link ArrowBuf}. */ @State(Scope.Benchmark) public class ArrowBufBenchmarks { @@ -46,18 +42,14 @@ public class ArrowBufBenchmarks { private ArrowBuf buffer; - /** - * Setup benchmarks. - */ + /** Setup benchmarks. */ @Setup public void prepare() { allocator = new RootAllocator(ALLOCATOR_CAPACITY); buffer = allocator.buffer(BUFFER_CAPACITY); } - /** - * Tear down benchmarks. - */ + /** Tear down benchmarks. */ @TearDown public void tearDown() { buffer.close(); @@ -72,10 +64,8 @@ public void setZero() { } public static void main(String[] args) throws RunnerException { - Options opt = new OptionsBuilder() - .include(ArrowBufBenchmarks.class.getSimpleName()) - .forks(1) - .build(); + Options opt = + new OptionsBuilder().include(ArrowBufBenchmarks.class.getSimpleName()).forks(1).build(); new Runner(opt).run(); } diff --git a/java/performance/src/main/java/org/apache/arrow/memory/util/ArrowBufPointerBenchmarks.java b/java/performance/src/main/java/org/apache/arrow/memory/util/ArrowBufPointerBenchmarks.java index 8e2c9cc51a346..3d82b46b094c6 100644 --- a/java/performance/src/main/java/org/apache/arrow/memory/util/ArrowBufPointerBenchmarks.java +++ b/java/performance/src/main/java/org/apache/arrow/memory/util/ArrowBufPointerBenchmarks.java @@ -14,11 +14,9 @@ * See the License for the specific language governing permissions and * limitations under the License. */ - package org.apache.arrow.memory.util; import java.util.concurrent.TimeUnit; - import org.apache.arrow.memory.ArrowBuf; import org.apache.arrow.memory.BufferAllocator; import org.apache.arrow.memory.RootAllocator; @@ -35,9 +33,7 @@ import org.openjdk.jmh.runner.options.Options; import org.openjdk.jmh.runner.options.OptionsBuilder; -/** - * Benchmarks for {@link ArrowBufPointer}. - */ +/** Benchmarks for {@link ArrowBufPointer}. */ @State(Scope.Benchmark) public class ArrowBufPointerBenchmarks { @@ -55,9 +51,7 @@ public class ArrowBufPointerBenchmarks { private ArrowBufPointer pointer2; - /** - * Setup benchmarks. - */ + /** Setup benchmarks. */ @Setup public void prepare() { allocator = new RootAllocator(ALLOCATOR_CAPACITY); @@ -77,9 +71,7 @@ public void prepare() { pointer2 = new ArrowBufPointer(buffer2, 0, BUFFER_CAPACITY); } - /** - * Tear down benchmarks. - */ + /** Tear down benchmarks. */ @TearDown public void tearDown() { buffer1.close(); @@ -95,7 +87,8 @@ public int compareBenchmark() { } public static void main(String[] args) throws RunnerException { - Options opt = new OptionsBuilder() + Options opt = + new OptionsBuilder() .include(ArrowBufPointerBenchmarks.class.getSimpleName()) .forks(1) .build(); @@ -103,5 +96,3 @@ public static void main(String[] args) throws RunnerException { new Runner(opt).run(); } } - - diff --git a/java/performance/src/main/java/org/apache/arrow/memory/util/ByteFunctionHelpersBenchmarks.java b/java/performance/src/main/java/org/apache/arrow/memory/util/ByteFunctionHelpersBenchmarks.java index f1dc2d79eff83..c5f1036d69127 100644 --- a/java/performance/src/main/java/org/apache/arrow/memory/util/ByteFunctionHelpersBenchmarks.java +++ b/java/performance/src/main/java/org/apache/arrow/memory/util/ByteFunctionHelpersBenchmarks.java @@ -14,11 +14,9 @@ * See the License for the specific language governing permissions and * limitations under the License. */ - package org.apache.arrow.memory.util; import java.util.concurrent.TimeUnit; - import org.apache.arrow.memory.ArrowBuf; import org.apache.arrow.memory.BufferAllocator; import org.apache.arrow.memory.RootAllocator; @@ -36,15 +34,14 @@ import org.openjdk.jmh.runner.options.Options; import org.openjdk.jmh.runner.options.OptionsBuilder; -/** - * Benchmarks for {@link ByteFunctionHelpers}. - */ +/** Benchmarks for {@link ByteFunctionHelpers}. */ public class ByteFunctionHelpersBenchmarks { private static final int ALLOCATOR_CAPACITY = 1024 * 1024; /** - * State object for the {@link ByteFunctionHelpersBenchmarks#arrowBufEquals(ArrowEqualState)} benchmark. + * State object for the {@link ByteFunctionHelpersBenchmarks#arrowBufEquals(ArrowEqualState)} + * benchmark. */ @State(Scope.Benchmark) public static class ArrowEqualState { @@ -81,12 +78,18 @@ public void tearDown() { @BenchmarkMode(Mode.AverageTime) @OutputTimeUnit(TimeUnit.NANOSECONDS) public void arrowBufEquals(ArrowEqualState state) { - ByteFunctionHelpers.equal(state.buffer1, 0, ArrowEqualState.BUFFER_CAPACITY - 1, - state.buffer2, 0, ArrowEqualState.BUFFER_CAPACITY - 1); + ByteFunctionHelpers.equal( + state.buffer1, + 0, + ArrowEqualState.BUFFER_CAPACITY - 1, + state.buffer2, + 0, + ArrowEqualState.BUFFER_CAPACITY - 1); } /** - * State object for the {@link ByteFunctionHelpersBenchmarks#arrowBufArrayEquals(ArrowArrayEqualState)} benchmark. + * State object for the {@link + * ByteFunctionHelpersBenchmarks#arrowBufArrayEquals(ArrowArrayEqualState)} benchmark. */ @State(Scope.Benchmark) public static class ArrowArrayEqualState { @@ -123,15 +126,20 @@ public void tearDown() { @OutputTimeUnit(TimeUnit.NANOSECONDS) public int arrowBufArrayEquals(ArrowArrayEqualState state) { return ByteFunctionHelpers.compare( - state.buffer1, 0, ArrowArrayEqualState.BUFFER_CAPACITY, - state.buffer2, 0, ArrowArrayEqualState.BUFFER_CAPACITY); + state.buffer1, + 0, + ArrowArrayEqualState.BUFFER_CAPACITY, + state.buffer2, + 0, + ArrowArrayEqualState.BUFFER_CAPACITY); } public static void main(String[] args) throws RunnerException { - Options opt = new OptionsBuilder() - .include(ByteFunctionHelpersBenchmarks.class.getSimpleName()) - .forks(1) - .build(); + Options opt = + new OptionsBuilder() + .include(ByteFunctionHelpersBenchmarks.class.getSimpleName()) + .forks(1) + .build(); new Runner(opt).run(); } diff --git a/java/performance/src/main/java/org/apache/arrow/vector/BaseValueVectorBenchmarks.java b/java/performance/src/main/java/org/apache/arrow/vector/BaseValueVectorBenchmarks.java index 5d6441cd5a747..bd53b13823622 100644 --- a/java/performance/src/main/java/org/apache/arrow/vector/BaseValueVectorBenchmarks.java +++ b/java/performance/src/main/java/org/apache/arrow/vector/BaseValueVectorBenchmarks.java @@ -14,11 +14,9 @@ * See the License for the specific language governing permissions and * limitations under the License. */ - package org.apache.arrow.vector; import java.util.concurrent.TimeUnit; - import org.apache.arrow.memory.BufferAllocator; import org.apache.arrow.memory.RootAllocator; import org.openjdk.jmh.annotations.Benchmark; @@ -34,9 +32,7 @@ import org.openjdk.jmh.runner.options.Options; import org.openjdk.jmh.runner.options.OptionsBuilder; -/** - * Benchmarks for {@link BaseValueVector}. - */ +/** Benchmarks for {@link BaseValueVector}. */ @State(Scope.Benchmark) public class BaseValueVectorBenchmarks { @@ -48,9 +44,7 @@ public class BaseValueVectorBenchmarks { private IntVector vector; - /** - * Setup benchmarks. - */ + /** Setup benchmarks. */ @Setup public void prepare() { allocator = new RootAllocator(ALLOCATOR_CAPACITY); @@ -58,9 +52,7 @@ public void prepare() { vector.allocateNew(VECTOR_LENGTH); } - /** - * Tear down benchmarks. - */ + /** Tear down benchmarks. */ @TearDown public void tearDown() { vector.close(); @@ -69,6 +61,7 @@ public void tearDown() { /** * Test {@link BaseValueVector#computeCombinedBufferSize(int, int)}. + * * @return useless. To avoid DCE by JIT. */ @Benchmark @@ -82,14 +75,13 @@ public int testComputeCombinedBufferSize() { return totalSize; } - public static void main(String [] args) throws RunnerException { - Options opt = new OptionsBuilder() - .include(BaseValueVectorBenchmarks.class.getSimpleName()) - .forks(1) - .build(); + public static void main(String[] args) throws RunnerException { + Options opt = + new OptionsBuilder() + .include(BaseValueVectorBenchmarks.class.getSimpleName()) + .forks(1) + .build(); new Runner(opt).run(); } - - } diff --git a/java/performance/src/main/java/org/apache/arrow/vector/BitVectorHelperBenchmarks.java b/java/performance/src/main/java/org/apache/arrow/vector/BitVectorHelperBenchmarks.java index e29b889c6e7a8..f794efe91b88b 100644 --- a/java/performance/src/main/java/org/apache/arrow/vector/BitVectorHelperBenchmarks.java +++ b/java/performance/src/main/java/org/apache/arrow/vector/BitVectorHelperBenchmarks.java @@ -14,11 +14,9 @@ * See the License for the specific language governing permissions and * limitations under the License. */ - package org.apache.arrow.vector; import java.util.concurrent.TimeUnit; - import org.apache.arrow.memory.ArrowBuf; import org.apache.arrow.memory.BufferAllocator; import org.apache.arrow.memory.RootAllocator; @@ -37,15 +35,11 @@ import org.openjdk.jmh.runner.options.Options; import org.openjdk.jmh.runner.options.OptionsBuilder; -/** - * Benchmarks for {@link BitVectorHelper}. - */ +/** Benchmarks for {@link BitVectorHelper}. */ public class BitVectorHelperBenchmarks { // checkstyle:off: MissingJavadocMethod - /** - * State object for general benchmarks. - */ + /** State object for general benchmarks. */ @State(Scope.Benchmark) public static class BenchmarkState { @@ -59,9 +53,7 @@ public static class BenchmarkState { private ArrowBuf oneBitValidityBuffer; - /** - * Setup benchmarks. - */ + /** Setup benchmarks. */ @Setup(Level.Trial) public void prepare() { allocator = new RootAllocator(ALLOCATOR_CAPACITY); @@ -81,9 +73,7 @@ public void prepare() { BitVectorHelper.setBit(oneBitValidityBuffer, VALIDITY_BUFFER_CAPACITY / 2); } - /** - * Tear down benchmarks. - */ + /** Tear down benchmarks. */ @TearDown(Level.Trial) public void tearDown() { validityBuffer.close(); @@ -96,7 +86,8 @@ public void tearDown() { @BenchmarkMode(Mode.AverageTime) @OutputTimeUnit(TimeUnit.NANOSECONDS) public int getNullCountBenchmark(BenchmarkState state) { - return BitVectorHelper.getNullCount(state.validityBuffer, BenchmarkState.VALIDITY_BUFFER_CAPACITY); + return BitVectorHelper.getNullCount( + state.validityBuffer, BenchmarkState.VALIDITY_BUFFER_CAPACITY); } @Benchmark @@ -104,12 +95,10 @@ public int getNullCountBenchmark(BenchmarkState state) { @OutputTimeUnit(TimeUnit.NANOSECONDS) public boolean allBitsNullBenchmark(BenchmarkState state) { return BitVectorHelper.checkAllBitsEqualTo( - state.oneBitValidityBuffer, BenchmarkState.VALIDITY_BUFFER_CAPACITY, true); + state.oneBitValidityBuffer, BenchmarkState.VALIDITY_BUFFER_CAPACITY, true); } - /** - * State object for {@link #loadValidityBufferAllOne(NonNullableValidityBufferState)}.. - */ + /** State object for {@link #loadValidityBufferAllOne(NonNullableValidityBufferState)}.. */ @State(Scope.Benchmark) public static class NonNullableValidityBufferState { @@ -125,9 +114,7 @@ public static class NonNullableValidityBufferState { private ArrowFieldNode fieldNode; - /** - * Setup benchmarks. - */ + /** Setup benchmarks. */ @Setup(Level.Trial) public void prepare() { allocator = new RootAllocator(ALLOCATOR_CAPACITY); @@ -145,9 +132,7 @@ public void tearDownInvoke() { loadResult.close(); } - /** - * Tear down benchmarks. - */ + /** Tear down benchmarks. */ @TearDown(Level.Trial) public void tearDown() { validityBuffer.close(); @@ -156,19 +141,18 @@ public void tearDown() { } /** - * Benchmark for {@link BitVectorHelper#loadValidityBuffer(ArrowFieldNode, ArrowBuf, BufferAllocator)} - * when all elements are not null. + * Benchmark for {@link BitVectorHelper#loadValidityBuffer(ArrowFieldNode, ArrowBuf, + * BufferAllocator)} when all elements are not null. */ @Benchmark @BenchmarkMode(Mode.AverageTime) @OutputTimeUnit(TimeUnit.NANOSECONDS) public void loadValidityBufferAllOne(NonNullableValidityBufferState state) { - state.loadResult = BitVectorHelper.loadValidityBuffer(state.fieldNode, state.validityBuffer, state.allocator); + state.loadResult = + BitVectorHelper.loadValidityBuffer(state.fieldNode, state.validityBuffer, state.allocator); } - /** - * State object for {@link #setValidityBitBenchmark(ClearBitStateState)}. - */ + /** State object for {@link #setValidityBitBenchmark(ClearBitStateState)}. */ @State(Scope.Benchmark) public static class ClearBitStateState { @@ -182,18 +166,14 @@ public static class ClearBitStateState { private int bitToSet = 0; - /** - * Setup benchmarks. - */ + /** Setup benchmarks. */ @Setup(Level.Trial) public void prepare() { allocator = new RootAllocator(ALLOCATOR_CAPACITY); validityBuffer = allocator.buffer(VALIDITY_BUFFER_CAPACITY / 8); } - /** - * Tear down benchmarks. - */ + /** Tear down benchmarks. */ @TearDown(Level.Trial) public void tearDown() { validityBuffer.close(); @@ -219,8 +199,9 @@ public void setValidityBitToZeroBenchmark(ClearBitStateState state) { } } - public static void main(String [] args) throws RunnerException { - Options opt = new OptionsBuilder() + public static void main(String[] args) throws RunnerException { + Options opt = + new OptionsBuilder() .include(BitVectorHelperBenchmarks.class.getSimpleName()) .forks(1) .build(); diff --git a/java/performance/src/main/java/org/apache/arrow/vector/DecimalVectorBenchmarks.java b/java/performance/src/main/java/org/apache/arrow/vector/DecimalVectorBenchmarks.java index 72f5659907af0..6cb54bc62a3a6 100644 --- a/java/performance/src/main/java/org/apache/arrow/vector/DecimalVectorBenchmarks.java +++ b/java/performance/src/main/java/org/apache/arrow/vector/DecimalVectorBenchmarks.java @@ -14,12 +14,10 @@ * See the License for the specific language governing permissions and * limitations under the License. */ - package org.apache.arrow.vector; import java.math.BigDecimal; import java.util.concurrent.TimeUnit; - import org.apache.arrow.memory.ArrowBuf; import org.apache.arrow.memory.BufferAllocator; import org.apache.arrow.memory.RootAllocator; @@ -36,9 +34,7 @@ import org.openjdk.jmh.runner.options.Options; import org.openjdk.jmh.runner.options.OptionsBuilder; -/** - * Benchmarks for {@link DecimalVector}. - */ +/** Benchmarks for {@link DecimalVector}. */ @State(Scope.Benchmark) public class DecimalVectorBenchmarks { @@ -54,9 +50,7 @@ public class DecimalVectorBenchmarks { byte[] fromByteArray; - /** - * Setup benchmarks. - */ + /** Setup benchmarks. */ @Setup public void prepare() { allocator = new RootAllocator(ALLOCATOR_CAPACITY); @@ -73,9 +67,7 @@ public void prepare() { fromBuf.getBytes(0, fromByteArray); } - /** - * Tear down benchmarks. - */ + /** Tear down benchmarks. */ @TearDown public void tearDown() { fromBuf.close(); @@ -83,9 +75,7 @@ public void tearDown() { allocator.close(); } - /** - * Test writing on {@link DecimalVector} from arrow buf. - */ + /** Test writing on {@link DecimalVector} from arrow buf. */ @Benchmark @BenchmarkMode(Mode.AverageTime) @OutputTimeUnit(TimeUnit.MICROSECONDS) @@ -98,9 +88,7 @@ public void setBigEndianArrowBufBenchmark() { } } - /** - * Test writing on {@link DecimalVector} from byte array. - */ + /** Test writing on {@link DecimalVector} from byte array. */ @Benchmark @BenchmarkMode(Mode.AverageTime) @OutputTimeUnit(TimeUnit.MICROSECONDS) @@ -110,11 +98,12 @@ public void setBigEndianByteArrayBenchmark() { } } - public static void main(String [] args) throws RunnerException { - Options opt = new OptionsBuilder() - .include(DecimalVectorBenchmarks.class.getSimpleName()) - .forks(1) - .build(); + public static void main(String[] args) throws RunnerException { + Options opt = + new OptionsBuilder() + .include(DecimalVectorBenchmarks.class.getSimpleName()) + .forks(1) + .build(); new Runner(opt).run(); } diff --git a/java/performance/src/main/java/org/apache/arrow/vector/Float8Benchmarks.java b/java/performance/src/main/java/org/apache/arrow/vector/Float8Benchmarks.java index 36a633e5e1b6e..f2b6a134bdb57 100644 --- a/java/performance/src/main/java/org/apache/arrow/vector/Float8Benchmarks.java +++ b/java/performance/src/main/java/org/apache/arrow/vector/Float8Benchmarks.java @@ -14,11 +14,9 @@ * See the License for the specific language governing permissions and * limitations under the License. */ - package org.apache.arrow.vector; import java.util.concurrent.TimeUnit; - import org.apache.arrow.memory.BoundsChecking; import org.apache.arrow.memory.BufferAllocator; import org.apache.arrow.memory.RootAllocator; @@ -35,9 +33,7 @@ import org.openjdk.jmh.runner.options.Options; import org.openjdk.jmh.runner.options.OptionsBuilder; -/** - * Benchmarks for {@link Float8Vector}. - */ +/** Benchmarks for {@link Float8Vector}. */ @State(Scope.Benchmark) public class Float8Benchmarks { // checkstyle:off: MissingJavadocMethod @@ -52,9 +48,7 @@ public class Float8Benchmarks { private Float8Vector fromVector; - /** - * Setup benchmarks. - */ + /** Setup benchmarks. */ @Setup public void prepare() { allocator = new RootAllocator(ALLOCATOR_CAPACITY); @@ -74,9 +68,7 @@ public void prepare() { fromVector.setValueCount(VECTOR_LENGTH); } - /** - * Tear down benchmarks. - */ + /** Tear down benchmarks. */ @TearDown public void tearDown() { vector.close(); @@ -85,10 +77,11 @@ public void tearDown() { } /** - * Test reading/writing on {@link Float8Vector}. - * The performance of this benchmark is influenced by the states of two flags: - * 1. The flag for boundary checking. For details, please see {@link BoundsChecking}. - * 2. The flag for null checking in get methods. For details, please see {@link NullCheckingForGet}. + * Test reading/writing on {@link Float8Vector}. The performance of this benchmark is influenced + * by the states of two flags: 1. The flag for boundary checking. For details, please see {@link + * BoundsChecking}. 2. The flag for null checking in get methods. For details, please see {@link + * NullCheckingForGet}. + * * @return useless. To avoid DCE by JIT. */ @Benchmark @@ -112,11 +105,9 @@ public void copyFromBenchmark() { } } - public static void main(String [] args) throws RunnerException { - Options opt = new OptionsBuilder() - .include(Float8Benchmarks.class.getSimpleName()) - .forks(1) - .build(); + public static void main(String[] args) throws RunnerException { + Options opt = + new OptionsBuilder().include(Float8Benchmarks.class.getSimpleName()).forks(1).build(); new Runner(opt).run(); } diff --git a/java/performance/src/main/java/org/apache/arrow/vector/FloatingPointBenchmarks.java b/java/performance/src/main/java/org/apache/arrow/vector/FloatingPointBenchmarks.java index 2938591737f06..a7e6789889277 100644 --- a/java/performance/src/main/java/org/apache/arrow/vector/FloatingPointBenchmarks.java +++ b/java/performance/src/main/java/org/apache/arrow/vector/FloatingPointBenchmarks.java @@ -14,11 +14,9 @@ * See the License for the specific language governing permissions and * limitations under the License. */ - package org.apache.arrow.vector; import java.util.concurrent.TimeUnit; - import org.apache.arrow.memory.BufferAllocator; import org.apache.arrow.memory.RootAllocator; import org.apache.arrow.vector.compare.ApproxEqualsVisitor; @@ -36,9 +34,7 @@ import org.openjdk.jmh.runner.options.Options; import org.openjdk.jmh.runner.options.OptionsBuilder; -/** - * Benchmarks for floating point vectors. - */ +/** Benchmarks for floating point vectors. */ @State(Scope.Benchmark) public class FloatingPointBenchmarks { // checkstyle:off: MissingJavadocMethod @@ -63,9 +59,7 @@ public class FloatingPointBenchmarks { private Range range; - /** - * Setup benchmarks. - */ + /** Setup benchmarks. */ @Setup public void prepare() { allocator = new RootAllocator(ALLOCATOR_CAPACITY); @@ -102,9 +96,7 @@ public void prepare() { range = new Range(0, 0, VECTOR_LENGTH); } - /** - * Tear down benchmarks. - */ + /** Tear down benchmarks. */ @TearDown public void tearDown() { floatVector1.close(); @@ -123,8 +115,9 @@ public int approxEqualsBenchmark() { return (floatResult ? 1 : 0) + (doubleResult ? 1 : 0); } - public static void main(String [] args) throws RunnerException { - Options opt = new OptionsBuilder() + public static void main(String[] args) throws RunnerException { + Options opt = + new OptionsBuilder() .include(FloatingPointBenchmarks.class.getSimpleName()) .forks(1) .build(); @@ -133,4 +126,3 @@ public static void main(String [] args) throws RunnerException { } // checkstyle:on: MissingJavadocMethod } - diff --git a/java/performance/src/main/java/org/apache/arrow/vector/IntBenchmarks.java b/java/performance/src/main/java/org/apache/arrow/vector/IntBenchmarks.java index 99674058970a6..315f1f83ccdee 100644 --- a/java/performance/src/main/java/org/apache/arrow/vector/IntBenchmarks.java +++ b/java/performance/src/main/java/org/apache/arrow/vector/IntBenchmarks.java @@ -14,11 +14,9 @@ * See the License for the specific language governing permissions and * limitations under the License. */ - package org.apache.arrow.vector; import java.util.concurrent.TimeUnit; - import org.apache.arrow.memory.BufferAllocator; import org.apache.arrow.memory.RootAllocator; import org.apache.arrow.vector.complex.impl.IntWriterImpl; @@ -36,9 +34,7 @@ import org.openjdk.jmh.runner.options.Options; import org.openjdk.jmh.runner.options.OptionsBuilder; -/** - * Benchmarks for {@link IntVector}. - */ +/** Benchmarks for {@link IntVector}. */ @State(Scope.Benchmark) public class IntBenchmarks { // checkstyle:off: MissingJavadocMethod @@ -100,11 +96,9 @@ public void setWithWriter() { } } - public static void main(String [] args) throws RunnerException { - Options opt = new OptionsBuilder() - .include(IntBenchmarks.class.getSimpleName()) - .forks(1) - .build(); + public static void main(String[] args) throws RunnerException { + Options opt = + new OptionsBuilder().include(IntBenchmarks.class.getSimpleName()).forks(1).build(); new Runner(opt).run(); } diff --git a/java/performance/src/main/java/org/apache/arrow/vector/VarCharBenchmarks.java b/java/performance/src/main/java/org/apache/arrow/vector/VarCharBenchmarks.java index a7ce4e04fee87..b3924a7dd9461 100644 --- a/java/performance/src/main/java/org/apache/arrow/vector/VarCharBenchmarks.java +++ b/java/performance/src/main/java/org/apache/arrow/vector/VarCharBenchmarks.java @@ -14,11 +14,9 @@ * See the License for the specific language governing permissions and * limitations under the License. */ - package org.apache.arrow.vector; import java.util.concurrent.TimeUnit; - import org.apache.arrow.memory.BufferAllocator; import org.apache.arrow.memory.RootAllocator; import org.openjdk.jmh.annotations.Benchmark; @@ -34,9 +32,7 @@ import org.openjdk.jmh.runner.options.Options; import org.openjdk.jmh.runner.options.OptionsBuilder; -/** - * Benchmarks for {@link VarCharVector}. - */ +/** Benchmarks for {@link VarCharVector}. */ @State(Scope.Benchmark) public class VarCharBenchmarks { // checkstyle:off: MissingJavadocMethod @@ -51,9 +47,7 @@ public class VarCharBenchmarks { private VarCharVector fromVector; - /** - * Setup benchmarks. - */ + /** Setup benchmarks. */ @Setup public void prepare() { allocator = new RootAllocator(ALLOCATOR_CAPACITY); @@ -73,9 +67,7 @@ public void prepare() { fromVector.setValueCount(VECTOR_LENGTH); } - /** - * Tear down benchmarks. - */ + /** Tear down benchmarks. */ @TearDown public void tearDown() { vector.close(); @@ -92,11 +84,9 @@ public void copyFromBenchmark() { } } - public static void main(String [] args) throws RunnerException { - Options opt = new OptionsBuilder() - .include(VarCharBenchmarks.class.getSimpleName()) - .forks(1) - .build(); + public static void main(String[] args) throws RunnerException { + Options opt = + new OptionsBuilder().include(VarCharBenchmarks.class.getSimpleName()).forks(1).build(); new Runner(opt).run(); } diff --git a/java/performance/src/main/java/org/apache/arrow/vector/VariableWidthVectorBenchmarks.java b/java/performance/src/main/java/org/apache/arrow/vector/VariableWidthVectorBenchmarks.java index 62c54606e6da6..0bce6569d268f 100644 --- a/java/performance/src/main/java/org/apache/arrow/vector/VariableWidthVectorBenchmarks.java +++ b/java/performance/src/main/java/org/apache/arrow/vector/VariableWidthVectorBenchmarks.java @@ -14,11 +14,9 @@ * See the License for the specific language governing permissions and * limitations under the License. */ - package org.apache.arrow.vector; import java.util.concurrent.TimeUnit; - import org.apache.arrow.memory.ArrowBuf; import org.apache.arrow.memory.BufferAllocator; import org.apache.arrow.memory.RootAllocator; @@ -36,9 +34,7 @@ import org.openjdk.jmh.runner.options.Options; import org.openjdk.jmh.runner.options.OptionsBuilder; -/** - * Benchmarks for {@link BaseVariableWidthVector}. - */ +/** Benchmarks for {@link BaseVariableWidthVector}. */ @State(Scope.Benchmark) public class VariableWidthVectorBenchmarks { // checkstyle:off: MissingJavadocMethod @@ -56,9 +52,7 @@ public class VariableWidthVectorBenchmarks { private VarCharVector vector; - /** - * Setup benchmarks. - */ + /** Setup benchmarks. */ @Setup public void prepare() { allocator = new RootAllocator(ALLOCATOR_CAPACITY); @@ -68,9 +62,7 @@ public void prepare() { arrowBuff.setBytes(0, bytes, 0, bytes.length); } - /** - * Tear down benchmarks. - */ + /** Tear down benchmarks. */ @TearDown public void tearDown() { arrowBuff.close(); @@ -80,6 +72,7 @@ public void tearDown() { /** * Test {@link BaseVariableWidthVector#getValueCapacity()}. + * * @return useless. To avoid DCE by JIT. */ @Benchmark @@ -119,9 +112,9 @@ public int setSafeFromNullableVarcharHolder() { return vector.getBufferSize(); } - - public static void main(String [] args) throws RunnerException { - Options opt = new OptionsBuilder() + public static void main(String[] args) throws RunnerException { + Options opt = + new OptionsBuilder() .include(VariableWidthVectorBenchmarks.class.getSimpleName()) .forks(1) .build(); diff --git a/java/performance/src/main/java/org/apache/arrow/vector/VectorLoaderBenchmark.java b/java/performance/src/main/java/org/apache/arrow/vector/VectorLoaderBenchmark.java index e8e8c0cfbc1f3..85a4b33a4e5da 100644 --- a/java/performance/src/main/java/org/apache/arrow/vector/VectorLoaderBenchmark.java +++ b/java/performance/src/main/java/org/apache/arrow/vector/VectorLoaderBenchmark.java @@ -14,11 +14,9 @@ * See the License for the specific language governing permissions and * limitations under the License. */ - package org.apache.arrow.vector; import java.util.concurrent.TimeUnit; - import org.apache.arrow.memory.BufferAllocator; import org.apache.arrow.memory.RootAllocator; import org.apache.arrow.vector.ipc.message.ArrowRecordBatch; @@ -36,9 +34,7 @@ import org.openjdk.jmh.runner.options.Options; import org.openjdk.jmh.runner.options.OptionsBuilder; -/** - * Benchmarks for {@link VectorLoader}. - */ +/** Benchmarks for {@link VectorLoader}. */ public class VectorLoaderBenchmark { // checkstyle:off: MissingJavadocMethod @@ -46,9 +42,7 @@ public class VectorLoaderBenchmark { private static final int VECTOR_COUNT = 10; - /** - * State for vector load benchmark. - */ + /** State for vector load benchmark. */ @State(Scope.Benchmark) public static class LoadState { @@ -62,9 +56,7 @@ public static class LoadState { private VectorLoader loader; - /** - * Setup benchmarks. - */ + /** Setup benchmarks. */ @Setup(Level.Trial) public void prepare() { allocator = new RootAllocator(ALLOCATOR_CAPACITY); @@ -91,9 +83,7 @@ public void tearDownInvoke() { root.close(); } - /** - * Tear down benchmarks. - */ + /** Tear down benchmarks. */ @TearDown(Level.Trial) public void tearDown() { allocator.close(); @@ -108,10 +98,8 @@ public void loadBenchmark(LoadState state) { } public static void main(String[] args) throws RunnerException { - Options opt = new OptionsBuilder() - .include(VectorLoaderBenchmark.class.getSimpleName()) - .forks(1) - .build(); + Options opt = + new OptionsBuilder().include(VectorLoaderBenchmark.class.getSimpleName()).forks(1).build(); new Runner(opt).run(); } diff --git a/java/performance/src/main/java/org/apache/arrow/vector/VectorUnloaderBenchmark.java b/java/performance/src/main/java/org/apache/arrow/vector/VectorUnloaderBenchmark.java index b464f888fa85f..2f7edc6f8aa17 100644 --- a/java/performance/src/main/java/org/apache/arrow/vector/VectorUnloaderBenchmark.java +++ b/java/performance/src/main/java/org/apache/arrow/vector/VectorUnloaderBenchmark.java @@ -14,11 +14,9 @@ * See the License for the specific language governing permissions and * limitations under the License. */ - package org.apache.arrow.vector; import java.util.concurrent.TimeUnit; - import org.apache.arrow.memory.BufferAllocator; import org.apache.arrow.memory.RootAllocator; import org.apache.arrow.vector.ipc.message.ArrowRecordBatch; @@ -36,9 +34,7 @@ import org.openjdk.jmh.runner.options.Options; import org.openjdk.jmh.runner.options.OptionsBuilder; -/** - * Benchmarks for {@link VectorUnloader}. - */ +/** Benchmarks for {@link VectorUnloader}. */ @State(Scope.Benchmark) public class VectorUnloaderBenchmark { // checkstyle:off: MissingJavadocMethod @@ -49,15 +45,13 @@ public class VectorUnloaderBenchmark { private BufferAllocator allocator; - private VarCharVector [] vectors; + private VarCharVector[] vectors; private VectorUnloader unloader; private ArrowRecordBatch recordBatch; - /** - * Setup benchmarks. - */ + /** Setup benchmarks. */ @Setup(Level.Trial) public void prepare() { allocator = new RootAllocator(ALLOCATOR_CAPACITY); @@ -84,9 +78,7 @@ public void tearDownInvoke() { } } - /** - * Tear down benchmarks. - */ + /** Tear down benchmarks. */ @TearDown(Level.Trial) public void tearDown() { allocator.close(); @@ -100,7 +92,8 @@ public void unloadBenchmark() { } public static void main(String[] args) throws RunnerException { - Options opt = new OptionsBuilder() + Options opt = + new OptionsBuilder() .include(VectorUnloaderBenchmark.class.getSimpleName()) .forks(1) .build(); diff --git a/java/performance/src/main/java/org/apache/arrow/vector/dictionary/DictionaryEncoderBenchmarks.java b/java/performance/src/main/java/org/apache/arrow/vector/dictionary/DictionaryEncoderBenchmarks.java index 6dd887a324350..c24399dbca388 100644 --- a/java/performance/src/main/java/org/apache/arrow/vector/dictionary/DictionaryEncoderBenchmarks.java +++ b/java/performance/src/main/java/org/apache/arrow/vector/dictionary/DictionaryEncoderBenchmarks.java @@ -14,7 +14,6 @@ * See the License for the specific language governing permissions and * limitations under the License. */ - package org.apache.arrow.vector.dictionary; import java.nio.charset.StandardCharsets; @@ -22,7 +21,6 @@ import java.util.List; import java.util.Random; import java.util.concurrent.TimeUnit; - import org.apache.arrow.memory.BufferAllocator; import org.apache.arrow.memory.RootAllocator; import org.apache.arrow.vector.ValueVector; @@ -41,9 +39,7 @@ import org.openjdk.jmh.runner.options.Options; import org.openjdk.jmh.runner.options.OptionsBuilder; -/** - * Benchmarks for {@link DictionaryEncoder}. - */ +/** Benchmarks for {@link DictionaryEncoder}. */ @State(Scope.Benchmark) public class DictionaryEncoderBenchmarks { @@ -52,7 +48,6 @@ public class DictionaryEncoderBenchmarks { private static final int DATA_SIZE = 1000; private static final int KEY_SIZE = 100; - private static final int KEY_LENGTH = 10; private List keys = new ArrayList<>(); @@ -61,9 +56,7 @@ public class DictionaryEncoderBenchmarks { private VarCharVector dictionaryVector; - /** - * Setup benchmarks. - */ + /** Setup benchmarks. */ @Setup public void prepare() { @@ -89,12 +82,9 @@ public void prepare() { byte[] value = keys.get(i).getBytes(StandardCharsets.UTF_8); dictionaryVector.setSafe(i, value, 0, value.length); } - } - /** - * Tear down benchmarks. - */ + /** Tear down benchmarks. */ @TearDown public void tearDown() { vector.close(); @@ -105,13 +95,15 @@ public void tearDown() { /** * Test encode for {@link DictionaryEncoder}. + * * @return useless. To avoid DCE by JIT. */ @Benchmark @BenchmarkMode(Mode.AverageTime) @OutputTimeUnit(TimeUnit.NANOSECONDS) public int testEncode() { - Dictionary dictionary = new Dictionary(dictionaryVector, new DictionaryEncoding(1L, false, null)); + Dictionary dictionary = + new Dictionary(dictionaryVector, new DictionaryEncoding(1L, false, null)); final ValueVector encoded = DictionaryEncoder.encode(vector, dictionary); encoded.close(); return 0; @@ -137,10 +129,11 @@ private String generateUniqueKey(int length) { } public static void main(String[] args) throws RunnerException { - Options opt = new OptionsBuilder() - .include(DictionaryEncoderBenchmarks.class.getSimpleName()) - .forks(1) - .build(); + Options opt = + new OptionsBuilder() + .include(DictionaryEncoderBenchmarks.class.getSimpleName()) + .forks(1) + .build(); new Runner(opt).run(); } diff --git a/java/performance/src/main/java/org/apache/arrow/vector/ipc/WriteChannelBenchmark.java b/java/performance/src/main/java/org/apache/arrow/vector/ipc/WriteChannelBenchmark.java index 18efff11db9ff..4698d0acf0000 100644 --- a/java/performance/src/main/java/org/apache/arrow/vector/ipc/WriteChannelBenchmark.java +++ b/java/performance/src/main/java/org/apache/arrow/vector/ipc/WriteChannelBenchmark.java @@ -14,14 +14,12 @@ * See the License for the specific language governing permissions and * limitations under the License. */ - package org.apache.arrow.vector.ipc; import java.io.ByteArrayOutputStream; import java.io.IOException; import java.nio.channels.Channels; import java.util.concurrent.TimeUnit; - import org.openjdk.jmh.annotations.Benchmark; import org.openjdk.jmh.annotations.BenchmarkMode; import org.openjdk.jmh.annotations.Level; @@ -37,15 +35,11 @@ import org.openjdk.jmh.runner.options.Options; import org.openjdk.jmh.runner.options.OptionsBuilder; -/** - * Benchmarks for {@link WriteChannel}. - */ +/** Benchmarks for {@link WriteChannel}. */ public class WriteChannelBenchmark { // checkstyle:off: MissingJavadocMethod - /** - * State object for align benchmark. - */ + /** State object for align benchmark. */ @State(Scope.Benchmark) public static class AlignState { @@ -78,10 +72,8 @@ public void alignBenchmark(AlignState state) throws IOException { } public static void main(String[] args) throws RunnerException { - Options opt = new OptionsBuilder() - .include(WriteChannelBenchmark.class.getSimpleName()) - .forks(1) - .build(); + Options opt = + new OptionsBuilder().include(WriteChannelBenchmark.class.getSimpleName()).forks(1).build(); new Runner(opt).run(); } diff --git a/java/performance/src/main/java/org/apache/arrow/vector/ipc/message/ArrowRecordBatchBenchmarks.java b/java/performance/src/main/java/org/apache/arrow/vector/ipc/message/ArrowRecordBatchBenchmarks.java index b608bb4c1c590..9b2250ee72f17 100644 --- a/java/performance/src/main/java/org/apache/arrow/vector/ipc/message/ArrowRecordBatchBenchmarks.java +++ b/java/performance/src/main/java/org/apache/arrow/vector/ipc/message/ArrowRecordBatchBenchmarks.java @@ -14,13 +14,11 @@ * See the License for the specific language governing permissions and * limitations under the License. */ - package org.apache.arrow.vector.ipc.message; import java.util.ArrayList; import java.util.List; import java.util.concurrent.TimeUnit; - import org.apache.arrow.memory.BufferAllocator; import org.apache.arrow.memory.RootAllocator; import org.apache.arrow.vector.VarCharVector; @@ -37,9 +35,7 @@ import org.openjdk.jmh.runner.options.Options; import org.openjdk.jmh.runner.options.OptionsBuilder; -/** - * Benchmarks for {@link ArrowRecordBatch}. - */ +/** Benchmarks for {@link ArrowRecordBatch}. */ @State(Scope.Benchmark) public class ArrowRecordBatchBenchmarks { // checkstyle:off: MissingJavadocMethod @@ -56,9 +52,7 @@ public class ArrowRecordBatchBenchmarks { private List nodes; - /** - * Setup benchmarks. - */ + /** Setup benchmarks. */ @Setup public void prepare() { allocator = new RootAllocator(ALLOCATOR_CAPACITY); @@ -70,9 +64,7 @@ public void prepare() { nodes.add(new ArrowFieldNode(VECTOR_LENGTH, 0)); } - /** - * Tear down benchmarks. - */ + /** Tear down benchmarks. */ @TearDown public void tearDown() { vector.close(); @@ -83,13 +75,15 @@ public void tearDown() { @BenchmarkMode(Mode.AverageTime) @OutputTimeUnit(TimeUnit.NANOSECONDS) public long createAndGetLength() { - try (ArrowRecordBatch batch = new ArrowRecordBatch(VECTOR_LENGTH, nodes, vector.getFieldBuffers())) { + try (ArrowRecordBatch batch = + new ArrowRecordBatch(VECTOR_LENGTH, nodes, vector.getFieldBuffers())) { return batch.computeBodyLength(); } } - public static void main(String [] args) throws RunnerException { - Options opt = new OptionsBuilder() + public static void main(String[] args) throws RunnerException { + Options opt = + new OptionsBuilder() .include(ArrowRecordBatchBenchmarks.class.getSimpleName()) .forks(1) .build(); diff --git a/java/performance/src/main/java/org/apache/arrow/vector/util/TransferPairBenchmarks.java b/java/performance/src/main/java/org/apache/arrow/vector/util/TransferPairBenchmarks.java index 486862859f122..bb68d1848a4e2 100644 --- a/java/performance/src/main/java/org/apache/arrow/vector/util/TransferPairBenchmarks.java +++ b/java/performance/src/main/java/org/apache/arrow/vector/util/TransferPairBenchmarks.java @@ -14,12 +14,10 @@ * See the License for the specific language governing permissions and * limitations under the License. */ - package org.apache.arrow.vector.util; import java.nio.charset.StandardCharsets; import java.util.concurrent.TimeUnit; - import org.apache.arrow.memory.BufferAllocator; import org.apache.arrow.memory.RootAllocator; import org.apache.arrow.vector.IntVector; @@ -37,9 +35,7 @@ import org.openjdk.jmh.runner.options.Options; import org.openjdk.jmh.runner.options.OptionsBuilder; -/** - * Benchmarks for {@link TransferPair}. - */ +/** Benchmarks for {@link TransferPair}. */ @State(Scope.Benchmark) public class TransferPairBenchmarks { // checkstyle:off: MissingJavadocMethod @@ -54,9 +50,7 @@ public class TransferPairBenchmarks { private VarCharVector varCharVector; - /** - * Setup benchmarks. - */ + /** Setup benchmarks. */ @Setup public void prepare() { allocator = new RootAllocator(ALLOCATOR_CAPACITY); @@ -79,9 +73,7 @@ public void prepare() { varCharVector.setValueCount(VECTOR_LENGTH); } - /** - * Tear down benchmarks. - */ + /** Tear down benchmarks. */ @TearDown public void tearDown() { intVector.close(); @@ -113,11 +105,9 @@ public int splitAndTransferVarcharVector() { return 0; } - public static void main(String [] args) throws RunnerException { - Options opt = new OptionsBuilder() - .include(TransferPairBenchmarks.class.getSimpleName()) - .forks(1) - .build(); + public static void main(String[] args) throws RunnerException { + Options opt = + new OptionsBuilder().include(TransferPairBenchmarks.class.getSimpleName()).forks(1).build(); new Runner(opt).run(); }