Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line breaks in messages are ignored #24

Closed
drygdryg opened this issue Jul 22, 2024 · 2 comments
Closed

Line breaks in messages are ignored #24

drygdryg opened this issue Jul 22, 2024 · 2 comments

Comments

@drygdryg
Copy link
Contributor

drygdryg commented Jul 22, 2024

Rocket.Chat uses newlines to separate lines in messages. Showdown by default expects Markdown-style line breaks (two spaces and a newline).
We should pass simpleLineBreaks=true (doc) to the Showdown options to convert the newline character to <br>.

const converterOptions: showdown.ConverterOptions = {}

const converterOptions: showdown.ConverterOptions = { simpleLineBreaks: true }
@HerHde
Copy link
Collaborator

HerHde commented Jul 25, 2024

Thank you also for this addition, implemented in d0ea576

@HerHde HerHde closed this as completed Jul 25, 2024
@HerHde
Copy link
Collaborator

HerHde commented Jul 25, 2024

Related to #29: "Showdown parses differently than Element (and probably also different from RocketChat)"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants