diff --git a/crates/turborepo-auth/src/lib.rs b/crates/turborepo-auth/src/lib.rs index 73570e5ef7db9..b2342a6334356 100644 --- a/crates/turborepo-auth/src/lib.rs +++ b/crates/turborepo-auth/src/lib.rs @@ -328,9 +328,8 @@ async fn run_sso_one_shot_server( #[cfg(test)] mod test { - use port_scanner; + use reqwest::Url; - use tokio; use turborepo_ui::UI; use turborepo_vercel_api_mock::start_test_server; diff --git a/crates/turborepo-cache/src/http.rs b/crates/turborepo-cache/src/http.rs index 5bd61bc81f84b..ba34177b78065 100644 --- a/crates/turborepo-cache/src/http.rs +++ b/crates/turborepo-cache/src/http.rs @@ -224,7 +224,7 @@ mod test { duration, } = test_case; - let api_client = APIClient::new(&format!("http://localhost:{}", port), 200, "2.0.0", true)?; + let api_client = APIClient::new(format!("http://localhost:{}", port), 200, "2.0.0", true)?; let opts = CacheOpts::default(); let api_auth = APIAuth { team_id: "my-team".to_string(), diff --git a/crates/turborepo-lib/src/config/turbo_config.rs b/crates/turborepo-lib/src/config/turbo_config.rs index b6045e1a1a1cd..2be93410c7718 100644 --- a/crates/turborepo-lib/src/config/turbo_config.rs +++ b/crates/turborepo-lib/src/config/turbo_config.rs @@ -494,9 +494,9 @@ mod test { assert_eq!(defaults.team_slug(), None); assert_eq!(defaults.team_id(), None); assert_eq!(defaults.token(), None); - assert_eq!(defaults.signature(), false); - assert_eq!(defaults.enabled(), true); - assert_eq!(defaults.preflight(), false); + assert!(!defaults.signature()); + assert!(defaults.enabled()); + assert!(!defaults.preflight()); assert_eq!(defaults.timeout(), DEFAULT_TIMEOUT); } diff --git a/crates/turborepo-lib/src/tracing.rs b/crates/turborepo-lib/src/tracing.rs index 9000d0e404fd3..87796eafff40d 100644 --- a/crates/turborepo-lib/src/tracing.rs +++ b/crates/turborepo-lib/src/tracing.rs @@ -1,9 +1,4 @@ -use std::{ - marker::PhantomData, - path::Path, - rc::Rc, - sync::{Arc, Mutex}, -}; +use std::{marker::PhantomData, path::Path, sync::Mutex}; use chrono::Local; use owo_colors::{ @@ -11,10 +6,7 @@ use owo_colors::{ Color, OwoColorize, }; use tracing::{field::Visit, metadata::LevelFilter, trace, Event, Level, Subscriber}; -use tracing_appender::{ - non_blocking::{NonBlocking, WorkerGuard}, - rolling::RollingFileAppender, -}; +use tracing_appender::{non_blocking::NonBlocking, rolling::RollingFileAppender}; use tracing_chrome::ChromeLayer; use tracing_subscriber::{ filter::{Filtered, Targets}, diff --git a/crates/turborepo-pidlock/src/lib.rs b/crates/turborepo-pidlock/src/lib.rs index 0da02d8122ddf..b1a64e7b254c7 100644 --- a/crates/turborepo-pidlock/src/lib.rs +++ b/crates/turborepo-pidlock/src/lib.rs @@ -210,7 +210,7 @@ impl Pidlock { })?; Ok(Some(pid)) } - Ok(pid) => { + Ok(_pid) => { warn!("stale pid file at {:?}", self.path); if let Err(e) = fs::remove_file(&self.path) { Err(PidFileError::FailedDelete( diff --git a/crates/turborepo-repository/src/inference.rs b/crates/turborepo-repository/src/inference.rs index 5712caa562679..e64686a25fb9a 100644 --- a/crates/turborepo-repository/src/inference.rs +++ b/crates/turborepo-repository/src/inference.rs @@ -72,17 +72,17 @@ impl RepoState { .filter_map(|path| { PackageJson::load(&path.join_component("package.json")) .ok() - .and_then(|package_json| { + .map(|package_json| { // FIXME: We should save this package manager that we detected let workspace_globs = PackageManager::get_package_manager(path, Some(&package_json)) .and_then(|mgr| mgr.get_workspace_globs(path)) .ok(); - Some(InferInfo { + InferInfo { path: path.to_owned(), workspace_globs, - }) + } }) }) .reduce(|current, candidate| { diff --git a/crates/turborepo-scm/src/manual.rs b/crates/turborepo-scm/src/manual.rs index 905fbaf150099..3b558675b457a 100644 --- a/crates/turborepo-scm/src/manual.rs +++ b/crates/turborepo-scm/src/manual.rs @@ -205,12 +205,12 @@ mod tests { let root_ignore_file = turbo_root.join_component(".gitignore"); root_ignore_file - .create_with_contents(&root_ignore_contents) + .create_with_contents(root_ignore_contents) .unwrap(); let pkg_ignore_file = turbo_root.resolve(&pkg_path).join_component(".gitignore"); pkg_ignore_file.ensure_dir().unwrap(); pkg_ignore_file - .create_with_contents(&pkg_ignore_contents) + .create_with_contents(pkg_ignore_contents) .unwrap(); let mut expected = GitHashes::new();