From 3c2ced99c0cdbb11bf175c34adb64d9560b66841 Mon Sep 17 00:00:00 2001 From: Andreas Fink Date: Sun, 24 Oct 2021 00:26:53 +0200 Subject: [PATCH 1/5] fix react-native issue --- src/utils/web-preset.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/utils/web-preset.ts b/src/utils/web-preset.ts index 29d09b803..bcb558502 100644 --- a/src/utils/web-preset.ts +++ b/src/utils/web-preset.ts @@ -12,13 +12,13 @@ let online = true const isOnline = () => online // For node and React Native, `add/removeEventListener` doesn't exist on window. -const onWindowEvent = hasWindow ? window.addEventListener.bind(window) : noop +const onWindowEvent = hasWindow ? window.addEventListener?.bind?.(window) || noop : noop const onDocumentEvent = hasDocument - ? document.addEventListener.bind(document) + ? document.addEventListener?.bind?.(document) || noop : noop const offWindowEvent = (hasWindow && removeEventListener) || noop const offDocumentEvent = hasDocument - ? document.removeEventListener.bind(document) + ? document.removeEventListener?.bind?.(document) || noop : noop const isVisible = () => { From 714c973579e9f5bf6ee8b875d53e7d6442ba923b Mon Sep 17 00:00:00 2001 From: Andreas Fink Date: Sun, 24 Oct 2021 00:57:05 +0200 Subject: [PATCH 2/5] v1.1.0-beta.9 --- package.json | 4 ++-- src/utils/web-preset.ts | 22 ++++++++++++++-------- 2 files changed, 16 insertions(+), 10 deletions(-) diff --git a/package.json b/package.json index f88c567a6..7d497fd5b 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { - "name": "swr", - "version": "1.1.0-beta.5", + "name": "swr-fixed-react-native", + "version": "1.1.0-beta.9", "description": "React Hooks library for remote data fetching", "main": "./dist/index.js", "module": "./dist/index.esm.js", diff --git a/src/utils/web-preset.ts b/src/utils/web-preset.ts index bcb558502..7b1b05743 100644 --- a/src/utils/web-preset.ts +++ b/src/utils/web-preset.ts @@ -12,14 +12,20 @@ let online = true const isOnline = () => online // For node and React Native, `add/removeEventListener` doesn't exist on window. -const onWindowEvent = hasWindow ? window.addEventListener?.bind?.(window) || noop : noop -const onDocumentEvent = hasDocument - ? document.addEventListener?.bind?.(document) || noop - : noop -const offWindowEvent = (hasWindow && removeEventListener) || noop -const offDocumentEvent = hasDocument - ? document.removeEventListener?.bind?.(document) || noop - : noop +const onWindowEvent = + hasWindow && window.addEventListener + ? window.addEventListener.bind(window) + : noop +const onDocumentEvent = + hasDocument && document.addEventListener + ? document.addEventListener.bind(document) + : noop +const offWindowEvent = + hasWindow && window.removeEventListener ? removeEventListener : noop +const offDocumentEvent = + hasDocument && document.removeEventListener + ? document.removeEventListener.bind(document) + : noop const isVisible = () => { const visibilityState = hasDocument && document.visibilityState From 369d162ba0ef1b378cce45a0d4b61d2334b56f81 Mon Sep 17 00:00:00 2001 From: Andreas Fink Date: Sun, 24 Oct 2021 00:59:40 +0200 Subject: [PATCH 3/5] update rn-fix --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 7d497fd5b..52435d7cb 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "swr-fixed-react-native", - "version": "1.1.0-beta.9", + "version": "1.1.0-beta.6", "description": "React Hooks library for remote data fetching", "main": "./dist/index.js", "module": "./dist/index.esm.js", From 5362e376917837978c072101f3eee80f8ee44347 Mon Sep 17 00:00:00 2001 From: Andreas Fink Date: Sun, 24 Oct 2021 01:00:25 +0200 Subject: [PATCH 4/5] fix naming --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 52435d7cb..b57d8ef69 100644 --- a/package.json +++ b/package.json @@ -1,5 +1,5 @@ { - "name": "swr-fixed-react-native", + "name": "swr", "version": "1.1.0-beta.6", "description": "React Hooks library for remote data fetching", "main": "./dist/index.js", From f3c069b2cc1639c6295675edac077bfa5f8916a0 Mon Sep 17 00:00:00 2001 From: Andreas Fink Date: Sun, 24 Oct 2021 11:06:16 +0200 Subject: [PATCH 5/5] check not needed for document --- src/utils/web-preset.ts | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/src/utils/web-preset.ts b/src/utils/web-preset.ts index 7b1b05743..06ba84081 100644 --- a/src/utils/web-preset.ts +++ b/src/utils/web-preset.ts @@ -16,16 +16,14 @@ const onWindowEvent = hasWindow && window.addEventListener ? window.addEventListener.bind(window) : noop -const onDocumentEvent = - hasDocument && document.addEventListener - ? document.addEventListener.bind(document) - : noop +const onDocumentEvent = hasDocument + ? document.addEventListener.bind(document) + : noop const offWindowEvent = hasWindow && window.removeEventListener ? removeEventListener : noop -const offDocumentEvent = - hasDocument && document.removeEventListener - ? document.removeEventListener.bind(document) - : noop +const offDocumentEvent = hasDocument + ? document.removeEventListener.bind(document) + : noop const isVisible = () => { const visibilityState = hasDocument && document.visibilityState