From 745d28ac9e73a904c223ce597d9d67bb2f18f2ac Mon Sep 17 00:00:00 2001 From: JJ Kasper Date: Thu, 27 Jan 2022 12:06:21 -0600 Subject: [PATCH 1/3] Move custom server note from middleware doc --- docs/advanced-features/custom-server.md | 8 +++++--- docs/middleware.md | 12 ------------ 2 files changed, 5 insertions(+), 15 deletions(-) diff --git a/docs/advanced-features/custom-server.md b/docs/advanced-features/custom-server.md index d476b52c08edc..a1797f46a69f5 100644 --- a/docs/advanced-features/custom-server.md +++ b/docs/advanced-features/custom-server.md @@ -28,8 +28,10 @@ const { createServer } = require('http') const { parse } = require('url') const next = require('next') +const port = 3000 const dev = process.env.NODE_ENV !== 'production' -const app = next({ dev }) +// when using middleware `hostname` and `port` must be provided below +const app = next({ dev, hostname: 'localhost', port }) const handle = app.getRequestHandler() app.prepare().then(() => { @@ -46,9 +48,9 @@ app.prepare().then(() => { } else { handle(req, res, parsedUrl) } - }).listen(3000, (err) => { + }).listen(port, (err) => { if (err) throw err - console.log('> Ready on http://localhost:3000') + console.log(`> Ready on http://localhost:${port}`) }) }) ``` diff --git a/docs/middleware.md b/docs/middleware.md index a660afd0f81c3..327f61179675e 100644 --- a/docs/middleware.md +++ b/docs/middleware.md @@ -76,18 +76,6 @@ Middleware runs directly after `redirects` and `headers`, before the first files Middleware uses a [strict runtime](/docs/api-reference/edge-runtime.md) that supports standard Web APIs like `fetch`. This works out of the box using `next start`, as well as on Edge platforms like Vercel, which use [Edge Functions](http://www.vercel.com/edge). -## Custom Server - -When using a custom server with middleware, you must specify the hostname and port when instantiating your `NextApp`. - -```ts -import next from 'next' -// ... -const port = process.env.PORT ? +process.env.PORT : 3000 -const dev = process.env.NODE_ENV !== 'production' -const app = next({ dev, customServer: true, hostname: 'localhost', port }) -``` - ## Related
From 68e0c604b4c08cae8c66213b679e421daf290e4a Mon Sep 17 00:00:00 2001 From: JJ Kasper Date: Thu, 27 Jan 2022 14:56:54 -0600 Subject: [PATCH 2/3] add variable for hostname --- docs/advanced-features/custom-server.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/docs/advanced-features/custom-server.md b/docs/advanced-features/custom-server.md index a1797f46a69f5..e1b174b8cc641 100644 --- a/docs/advanced-features/custom-server.md +++ b/docs/advanced-features/custom-server.md @@ -28,10 +28,11 @@ const { createServer } = require('http') const { parse } = require('url') const next = require('next') -const port = 3000 const dev = process.env.NODE_ENV !== 'production' +const hostname = 'localhost' +const port = 3000 // when using middleware `hostname` and `port` must be provided below -const app = next({ dev, hostname: 'localhost', port }) +const app = next({ dev, hostname, port }) const handle = app.getRequestHandler() app.prepare().then(() => { From c5610932213080724bdfcadac8ce75e3417d8e5c Mon Sep 17 00:00:00 2001 From: JJ Kasper Date: Thu, 27 Jan 2022 14:57:36 -0600 Subject: [PATCH 3/3] update log --- docs/advanced-features/custom-server.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/advanced-features/custom-server.md b/docs/advanced-features/custom-server.md index e1b174b8cc641..d887c841025c1 100644 --- a/docs/advanced-features/custom-server.md +++ b/docs/advanced-features/custom-server.md @@ -51,7 +51,7 @@ app.prepare().then(() => { } }).listen(port, (err) => { if (err) throw err - console.log(`> Ready on http://localhost:${port}`) + console.log(`> Ready on http://${hostname}:${port}`) }) }) ```