From ce994365b74b89d97dff90707158bb63c99687de Mon Sep 17 00:00:00 2001 From: Jesse Jafa Date: Sun, 30 Aug 2020 09:53:29 +0300 Subject: [PATCH] Add cross-env to ensure examples work on Windows 10 (#16694) Closes https://github.com/vercel/next.js/issues/16693 --- examples/custom-server/package.json | 3 ++- examples/ssr-caching/package.json | 3 ++- examples/with-algolia-react-instantsearch/package.json | 3 ++- examples/with-firebase-cloud-messaging/package.json | 3 ++- examples/with-http2/package.json | 3 ++- examples/with-react-intl/package.json | 5 +++-- 6 files changed, 13 insertions(+), 7 deletions(-) diff --git a/examples/custom-server/package.json b/examples/custom-server/package.json index 724fd2bf64dce..9999c380154a2 100644 --- a/examples/custom-server/package.json +++ b/examples/custom-server/package.json @@ -4,9 +4,10 @@ "scripts": { "dev": "node server.js", "build": "next build", - "start": "NODE_ENV=production node server.js" + "start": "cross-env NODE_ENV=production node server.js" }, "dependencies": { + "cross-env": "^7.0.2", "next": "latest", "react": "^16.13.1", "react-dom": "^16.13.1" diff --git a/examples/ssr-caching/package.json b/examples/ssr-caching/package.json index d324864f016de..b792220fbda09 100644 --- a/examples/ssr-caching/package.json +++ b/examples/ssr-caching/package.json @@ -4,10 +4,11 @@ "scripts": { "dev": "node server.js", "build": "next build", - "start": "NODE_ENV=production node server.js" + "start": "cross-env NODE_ENV=production node server.js" }, "dependencies": { "cacheable-response": "^1.1.0", + "cross-env": "^7.0.2", "express": "^4.14.0", "next": "latest", "react": "^16.7.0", diff --git a/examples/with-algolia-react-instantsearch/package.json b/examples/with-algolia-react-instantsearch/package.json index ed2b535bff80d..e4ff8ddc4b589 100644 --- a/examples/with-algolia-react-instantsearch/package.json +++ b/examples/with-algolia-react-instantsearch/package.json @@ -2,11 +2,12 @@ "name": "create-next-example-app", "scripts": { "dev": "next", - "build": "NODE_ENV=development next build", + "build": "cross-env NODE_ENV=development next build", "start": "next start" }, "dependencies": { "algoliasearch": "4.3.0", + "cross-env": "^7.0.2", "css-loader": "1.0.0", "next": "latest", "prop-types": "^15.5.10", diff --git a/examples/with-firebase-cloud-messaging/package.json b/examples/with-firebase-cloud-messaging/package.json index 601b0de164ae3..82253d5789fa9 100644 --- a/examples/with-firebase-cloud-messaging/package.json +++ b/examples/with-firebase-cloud-messaging/package.json @@ -4,9 +4,10 @@ "scripts": { "dev": "node server.js", "build": "next build", - "start": "NODE_ENV=production node server.js" + "start": "cross-env NODE_ENV=production node server.js" }, "dependencies": { + "cross-env": "^7.0.2", "express": "^4.14.0", "firebase": "^7.6.2", "localforage": "^1.7.3", diff --git a/examples/with-http2/package.json b/examples/with-http2/package.json index 90bd00f6518b5..b42874fd48bbf 100644 --- a/examples/with-http2/package.json +++ b/examples/with-http2/package.json @@ -4,9 +4,10 @@ "scripts": { "dev": "node server.js", "build": "next build", - "start": "NODE_ENV=production node server.js" + "start": "cross-env NODE_ENV=production node server.js" }, "dependencies": { + "cross-env": "^7.0.2", "next": "latest", "react": "^16.13.1", "react-dom": "^16.13.1" diff --git a/examples/with-react-intl/package.json b/examples/with-react-intl/package.json index 1b671bd5da877..4aa47f941d7f0 100644 --- a/examples/with-react-intl/package.json +++ b/examples/with-react-intl/package.json @@ -2,11 +2,11 @@ "name": "with-react-intl", "version": "1.0.0", "scripts": { - "dev": "NODE_ICU_DATA=node_modules/full-icu ts-node --project tsconfig.server.json server.ts", + "dev": "cross-env NODE_ICU_DATA=node_modules/full-icu ts-node --project tsconfig.server.json server.ts", "build": "npm run extract:i18n && npm run compile:i18n && next build && tsc -p tsconfig.server.json", "extract:i18n": "formatjs extract '{pages,components}/*.{js,ts,tsx}' --format simple --out-file lang/en.json", "compile:i18n": "formatjs compile-folder --ast --format simple lang/ compiled-lang/", - "start": "NODE_ENV=production NODE_ICU_DATA=node_modules/full-icu node dist/server" + "start": "cross-env NODE_ENV=production NODE_ICU_DATA=node_modules/full-icu node dist/server" }, "dependencies": { "@formatjs/cli": "^2.7.3", @@ -17,6 +17,7 @@ "@formatjs/intl-relativetimeformat": "^7.1.1", "accepts": "^1.3.7", "babel-plugin-react-intl": "^8.1.1", + "cross-env": "^7.0.2", "full-icu": "^1.3.0", "glob": "^7.1.4", "next": "latest",