diff --git a/.github/workflows/build_test_deploy.yml b/.github/workflows/build_test_deploy.yml index 6f21476395e41..b80919c6c35bd 100644 --- a/.github/workflows/build_test_deploy.yml +++ b/.github/workflows/build_test_deploy.yml @@ -911,12 +911,13 @@ jobs: testDeployE2E: name: E2E (deploy) runs-on: ubuntu-latest - needs: [publishRelease] + needs: [publishRelease, build, build-native-test] env: NEXT_TELEMETRY_DISABLED: 1 NEXT_TEST_JOB: 1 VERCEL_TEST_TOKEN: ${{ secrets.VERCEL_TEST_TOKEN }} VERCEL_TEST_TEAM: 'vtest314-next-e2e-tests' + NEXT_TEST_MODE: deploy steps: - name: Setup node uses: actions/setup-node@v3 @@ -930,13 +931,19 @@ jobs: path: ./* key: ${{ github.sha }}-${{ github.run_number }} + - uses: actions/download-artifact@v3 + if: ${{needs.build.outputs.docsChange != 'docs only change'}} + with: + name: next-swc-test-binary + path: packages/next-swc/native + - run: npm i -g playwright-chromium@1.14.1 && npx playwright install-deps name: Install playwright dependencies - run: RESET_VC_PROJECT=true node scripts/reset-vercel-project.mjs name: Reset test project - - run: NEXT_TEST_MODE=deploy node run-tests.js --type e2e + - run: node run-tests.js --type e2e name: Run test/e2e (deploy) - name: Upload test trace @@ -1411,7 +1418,7 @@ jobs: strategy: matrix: target: [web, nodejs] - runs-on: ubuntu-latest + runs-on: macos-latest steps: - uses: actions/cache@v3 id: restore-build diff --git a/docs/basic-features/data-fetching/incremental-static-regeneration.md b/docs/basic-features/data-fetching/incremental-static-regeneration.md index 85478a77556a4..ebc4cb73f18ba 100644 --- a/docs/basic-features/data-fetching/incremental-static-regeneration.md +++ b/docs/basic-features/data-fetching/incremental-static-regeneration.md @@ -139,7 +139,7 @@ $ next build $ next start ``` -Then, you are able to validate static pages are successfully revalidated. +Then, you can confirm that static pages have successfully revalidated. ## Error handling and revalidation diff --git a/errors/custom-document-image-import.md b/errors/custom-document-image-import.md index 64ff9af1e8fb6..c8970f2b91b1e 100644 --- a/errors/custom-document-image-import.md +++ b/errors/custom-document-image-import.md @@ -14,8 +14,8 @@ If your image needs to be displayed on every page you can relocate it to your [` ```jsx //pages/_app.js -import yourImage from "path/to/your/image" -import Image from "next/image" +import yourImage from 'path/to/your/image' +import Image from 'next/image' function MyApp({ Component, pageProps }) { return ( @@ -23,6 +23,7 @@ function MyApp({ Component, pageProps }) { your_image_description + ) } export default MyApp diff --git a/errors/next-script-for-ga.md b/errors/next-script-for-ga.md index 0785fcca17708..3df685bebcda9 100644 --- a/errors/next-script-for-ga.md +++ b/errors/next-script-for-ga.md @@ -15,7 +15,7 @@ import Script from 'next/script' function Home() { return ( -
+