Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VerificationMethod defined but not used #6

Closed
fhirfly opened this issue Jul 8, 2022 · 2 comments
Closed

VerificationMethod defined but not used #6

fhirfly opened this issue Jul 8, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@fhirfly
Copy link
Collaborator

fhirfly commented Jul 8, 2022

Prerequisites

Please answer the following questions for yourself before submitting an issue.

  • [ x] I am running the latest version
  • [ x] I checked the documentation and found no answer
  • [x ] I checked to make sure that this issue has not already been filed

Current Behavior

C:\Users\richb\Projects\ens-did-resolver\src\helpers.ts
1:10 warning 'VerificationMethod' is defined but never used @typescript-eslint/no-unused-vars

Expected Behavior

verificationMethod is properly taken from org.w3c.did.verificationMethod in ENS TEXT if present

Failure Information

Please help provide information about the failure.

Steps to Reproduce

Please provide detailed steps for reproducing the issue.

  1. run yarn package
  2. watch the build
  3. Run the resolver on did:ens:fhirfly.eth
  4. verificationMethod is not constructed from TEXT key.

Environment Details

Please provide any relevant information about your setup. This is important in case the issue is not reproducible except for under certain conditions.

Failure Logs/Screenshots

Please include any relevant log snippets or files here.
Create a GIST which is a paste of your full or sanitized logs, and link them here.
Please do NOT paste your full logs here, as it will make this issue very long and hard to read!

Alternatives you considered

Please provide details about an environment where this bug does not occur.


@fhirfly fhirfly added the bug Something isn't working label Jul 8, 2022
@fhirfly
Copy link
Collaborator Author

fhirfly commented Jul 8, 2022

code looks like it considers verificationMethod in resolver.ts in line 138

@mirceanis
Copy link

This was fixed in #4
Thank you for reporting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants