-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
factor: Add 32b variant for modular arithmetic #1554
Commits on Jul 4, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 43ee92c - Browse repository at this point
Copy the full SHA 43ee92cView commit details -
Configuration menu - View commit details
-
Copy full SHA for e68bb19 - Browse repository at this point
Copy the full SHA e68bb19View commit details -
Configuration menu - View commit details
-
Copy full SHA for a440807 - Browse repository at this point
Copy the full SHA a440807View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4d28f48 - Browse repository at this point
Copy the full SHA 4d28f48View commit details -
Configuration menu - View commit details
-
Copy full SHA for 774feb0 - Browse repository at this point
Copy the full SHA 774feb0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3f79be0 - Browse repository at this point
Copy the full SHA 3f79be0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2824441 - Browse repository at this point
Copy the full SHA 2824441View commit details -
Configuration menu - View commit details
-
Copy full SHA for caa79a1 - Browse repository at this point
Copy the full SHA caa79a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 19a8231 - Browse repository at this point
Copy the full SHA 19a8231View commit details -
Configuration menu - View commit details
-
Copy full SHA for 53954ba - Browse repository at this point
Copy the full SHA 53954baView commit details -
Configuration menu - View commit details
-
Copy full SHA for f95f977 - Browse repository at this point
Copy the full SHA f95f977View commit details -
Configuration menu - View commit details
-
Copy full SHA for b25c77c - Browse repository at this point
Copy the full SHA b25c77cView commit details -
Configuration menu - View commit details
-
Copy full SHA for d2b43f4 - Browse repository at this point
Copy the full SHA d2b43f4View commit details -
factor::miller_rabin::is_prime: Fix bug
Montgomery<_> only works for odd n, so attempting to construct an instance for an even number results in a panic! The most obvious solution is to special-case even numbers.
Configuration menu - View commit details
-
Copy full SHA for 3082903 - Browse repository at this point
Copy the full SHA 3082903View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0a1200b - Browse repository at this point
Copy the full SHA 0a1200bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 600268c - Browse repository at this point
Copy the full SHA 600268cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1e4d824 - Browse repository at this point
Copy the full SHA 1e4d824View commit details -
factor::miller_rabin::tests: small_composites → small_semiprimes
This is more descriptive, as semiprime are the products of 2 primes; all semiprimes are composite, but not all composite numbers are semiprime.
Configuration menu - View commit details
-
Copy full SHA for d2fa0fe - Browse repository at this point
Copy the full SHA d2fa0feView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4f08e28 - Browse repository at this point
Copy the full SHA 4f08e28View commit details -
factor::miller_rabin: Hoist edge-cases (even, <2) out of test()
test() takes a modulus that is known to not be even or <2 (otherwise the Montgomery value could not be constructed), so those checks can be hoisted into is_prime() and out of the critical path.
Configuration menu - View commit details
-
Copy full SHA for 9b149a7 - Browse repository at this point
Copy the full SHA 9b149a7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3d6fdff - Browse repository at this point
Copy the full SHA 3d6fdffView commit details -
factor::miller_rabin: Squash another bug! >:3
Detected by the testsuite improvement just prior.
Configuration menu - View commit details
-
Copy full SHA for cbcc760 - Browse repository at this point
Copy the full SHA cbcc760View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7a1b86c - Browse repository at this point
Copy the full SHA 7a1b86cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6256750 - Browse repository at this point
Copy the full SHA 6256750View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6e228d3 - Browse repository at this point
Copy the full SHA 6e228d3View commit details
Commits on Jul 15, 2020
-
Configuration menu - View commit details
-
Copy full SHA for c6276b7 - Browse repository at this point
Copy the full SHA c6276b7View commit details
Commits on Jul 21, 2020
-
factor::numeric::DoubleInt: Clarify methods and associated types
- `DoubleInt::Double` renamed to `DoubleWidth` - `{as,from}_double()` renamed to `{as,from}_double_width()`. This should hopefully clarify that this is not a “double precision” floating-point type, but an integer type with a larger range (used for storing intermediate results, typ. from a multiplication)
Configuration menu - View commit details
-
Copy full SHA for 96224f6 - Browse repository at this point
Copy the full SHA 96224f6View commit details -
factor::numeric::Int: Remove
from_u128
methodIt was unused, the debug assertions only need `to_u128`.
Configuration menu - View commit details
-
Copy full SHA for 141d813 - Browse repository at this point
Copy the full SHA 141d813View commit details -
Configuration menu - View commit details
-
Copy full SHA for 33a1c44 - Browse repository at this point
Copy the full SHA 33a1c44View commit details