Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

factor: Fix very-rare bug in ρ #1549

Merged
merged 4 commits into from
Jun 19, 2020
Merged

factor: Fix very-rare bug in ρ #1549

merged 4 commits into from
Jun 19, 2020

Commits on Jun 19, 2020

  1. factor::numeric::inv_mod_u64: Provide a more-helpful error message

    @nbraud
    nbraud committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    3a90e31 View commit details
    Browse the repository at this point in the history

  2. factor: Add test exhibiting a bug in ρ 

    The test is repeated 20 times to make it overwhelmingly-likely to fail
(the bug itself is only triggered rarely)
    @nbraud
    nbraud committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    9eb944b View commit details
    Browse the repository at this point in the history

  3. factor::rho: Fix very-unlikely bug (resulting in assertion failure) 

    This bug can only be triggered when:
- the Miller-Rabin test produces a divisor `d` (rare) ;
- n / d is prime.
    @nbraud
    nbraud committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    9fe3de7 View commit details
    Browse the repository at this point in the history

  4. fixup! factor: Add test exhibiting a bug in ρ

    @nbraud
    nbraud committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    45a1408 View commit details
    Browse the repository at this point in the history