Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

factor: Add/update copyright notices as necessary #1546

Merged
merged 2 commits into from
Jun 18, 2020
Merged

factor: Add/update copyright notices as necessary #1546

merged 2 commits into from
Jun 18, 2020

Conversation

nbraud
Copy link
Contributor

@nbraud nbraud commented Jun 18, 2020

I discovered yesterday that I accidentally failed to update/preserve those when
moving code around (#1525), deleting code (#1529), or adding my own
contributions.

This rectifies it, also adding years (based on git history) for all copyright
lines; I took the liberty not to track the individual changes for which
copyright is claimed, since that information is in git and tacking it by hand
would get out-of-hand very quickly.

- Add myself
- Remove kwantam (all contributions removed in 8a4d0d3, #1529)
Copyright lines were moved from factor.rs to match where code was moved to.
@sylvestre
Copy link
Sponsor Contributor

I am clearly not a fan for having a list of contributors in header (too strong sense of ownership, when do we add names, etc). we should have a global author file at the root directory.
but this is a discussion for another day!

@sylvestre sylvestre merged commit 4b4d11b into uutils:master Jun 18, 2020
@nbraud
Copy link
Contributor Author

nbraud commented Jun 19, 2020

I am clearly not a fan for having a list of contributors in header (too strong sense of ownership, when do we add names, etc). we should have a global author file at the root directory.
but this is a discussion for another day!

Yes, this is not my preferred solution either, but having it partially-there was strictly worse (and changing this convention for the entire project felt waaay outside my remit.)

@nbraud nbraud deleted the factor/copyright branch June 20, 2020 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants