v3.0.1 introduces breaking change and should be v4.0.0

[Bjvanminnen]

v3.0.0...v3.0.1

The changes in v3.0.1 make it so that const uuid = require('uuid'); no longer works. As such, I believe this should be bumping the major version number rather than the patch version.

This is getting https://github.com/request/request into trouble as it pins to ^3.0.0 which breaks on 3.0.1

[broofa]

Works for me.

kieffer@Roberts-MacBook-Pro$ \rm -fr node_modules/

kieffer@Roberts-MacBook-Pro$ npm install uuid request
/Users/kieffer/work
`-- request@2.79.0
  +-- aws-sign2@0.6.0
  +-- aws4@1.5.0
  +-- caseless@0.11.0
  +-- combined-stream@1.0.5
  | `-- delayed-stream@1.0.0
  +-- extend@3.0.0
  +-- forever-agent@0.6.1
  +-- form-data@2.1.2
  | `-- asynckit@0.4.0
  +-- har-validator@2.0.6
  | +-- chalk@1.1.3
  | | +-- ansi-styles@2.2.1
  | | +-- escape-string-regexp@1.0.5
  | | +-- has-ansi@2.0.0
  | | | `-- ansi-regex@2.0.0
  | | +-- strip-ansi@3.0.1
  | | `-- supports-color@2.0.0
  | +-- commander@2.9.0
  | | `-- graceful-readlink@1.0.1
  | +-- is-my-json-valid@2.15.0
  | | +-- generate-function@2.0.0
  | | +-- generate-object-property@1.2.0
  | | | `-- is-property@1.0.2
  | | +-- jsonpointer@4.0.0
  | | `-- xtend@4.0.1
  | `-- pinkie-promise@2.0.1
  |   `-- pinkie@2.0.4
  +-- hawk@3.1.3
  | +-- boom@2.10.1
  | +-- cryptiles@2.0.5
  | +-- hoek@2.16.3
  | `-- sntp@1.0.9
  +-- http-signature@1.1.1
  | +-- assert-plus@0.2.0
  | +-- jsprim@1.3.1
  | | +-- extsprintf@1.0.2
  | | +-- json-schema@0.2.3
  | | `-- verror@1.3.6
  | `-- sshpk@1.10.1
  |   +-- asn1@0.2.3
  |   +-- assert-plus@1.0.0
  |   +-- bcrypt-pbkdf@1.0.0
  |   +-- dashdash@1.14.1
  |   | `-- assert-plus@1.0.0
  |   +-- ecc-jsbn@0.1.1
  |   +-- getpass@0.1.6
  |   | `-- assert-plus@1.0.0
  |   +-- jodid25519@1.0.2
  |   +-- jsbn@0.1.0
  |   `-- tweetnacl@0.14.4
  +-- is-typedarray@1.0.0
  +-- isstream@0.1.2
  +-- json-stringify-safe@5.0.1
  +-- mime-types@2.1.13
  | `-- mime-db@1.25.0
  +-- oauth-sign@0.8.2
  +-- qs@6.3.0
  +-- stringstream@0.0.5
  +-- tough-cookie@2.3.2
  | `-- punycode@1.4.1
  +-- tunnel-agent@0.4.3
  `-- uuid@3.0.1

npm WARN enoent ENOENT: no such file or directory, open '/Users/kieffer/work/package.json'
npm WARN work No description
npm WARN work No repository field.
npm WARN work No README data
npm WARN work No license field.

kieffer@Roberts-MacBook-Pro$ node
> const uuid = require('uuid')
undefined
> const request = require('request')
undefined
> uuid()
'eeae5394-512b-4774-a39d-f96f74d677e8'
> var req = request('http://google.com')
undefined

[Bjvanminnen]

You're right. That appears to work for me too. Let me look into this a little further.

FWIW, this is the issue that prompted this yarnpkg/yarn#2072

[Bjvanminnen]

I haven't been able to get back into a repro state at this point, so I'm not too sure exactly what was wrong. Closing this issue.