Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Playground] Checkbox, Button,Image, Grid -In dark theme the label for components are not visible. #455

Open
sakshi173 opened this issue Feb 17, 2023 · 4 comments
Assignees
Labels
kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification.

Comments

@sakshi173
Copy link

Current behavior

Dark theme issue
Dark theme issue 2

Uno.Playground.-.Google.Chrome.2023-02-16.12-26-21.mp4

Expected behavior

In dark theme components label should display correctly.

How to reproduce it (as minimally and precisely as possible)

  1. Visit https://playgroundcanary.z19.web.core.windows.net/#passwordbox.
  2. Check 'Dark Theme' option.
  3. Go to the Snippets Listview.
  4. Click on 'Checkbox' or 'Button' snippets option.
  5. Observe that label is not correctly displaying for components.

Workaround

No response

Works on UWP/WinUI

None

Environment

No response

NuGet package version(s)

No response

Affected platforms

WebAssembly

IDE

No response

IDE version

No response

Relevant plugins

No response

Anything else we need to know?

No response

@sakshi173 sakshi173 added kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification. labels Feb 17, 2023
@Youssef1313 Youssef1313 self-assigned this Feb 17, 2023
@Youssef1313
Copy link
Member

Youssef1313 commented Feb 17, 2023

Looks like a problem in Playground default styles?

<Style x:Key="AndroidButtonStyle"

GitHub
Source code for the Uno Gallery apps and Uno Playground (made in Wasm) - Uno.Playground/DefaultStyles.xaml at 64c2ccf · unoplatform/Uno.Playground

@sakshi173 sakshi173 changed the title [Playground] Checkbox, Btton -In dark theme the label for components are not visible. [Playground] Checkbox, Button -In dark theme the label for components are not visible. Feb 17, 2023
@Youssef1313
Copy link
Member

Youssef1313 commented Feb 25, 2023

@sakshi173

image

Does this look good to you?

(CheckBox in progress)

@sakshi173
Copy link
Author

@Youssef1313, still I am seeing Button style is not correctly visible for dark theme. below is the screenshot from the current canary build.
button issue playground

@sakshi173 sakshi173 changed the title [Playground] Checkbox, Button -In dark theme the label for components are not visible. [Playground] Checkbox, Button,Image, Grid -In dark theme the label for components are not visible. Mar 15, 2023
@Youssef1313
Copy link
Member

@sakshi173 Yes, the PR #424 is not yet merged.

@MartinZikmund MartinZikmund transferred this issue from unoplatform/uno Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification.
Projects
None yet
Development

No branches or pull requests

2 participants