Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Django 4.2 #100

Merged
merged 9 commits into from
Jun 13, 2023
Merged

Add support for Django 4.2 #100

merged 9 commits into from
Jun 13, 2023

Conversation

johnthagen
Copy link
Contributor

@johnthagen johnthagen commented May 25, 2023

No description provided.

@johnthagen johnthagen marked this pull request as draft May 25, 2023 19:58
@johnthagen
Copy link
Contributor Author

I'm confused about why PyPy tests are failing? 🤔

@vinnyrose
Copy link
Collaborator

I'm confused about why PyPy tests are failing? 🤔

probably django/asgiref#393

@johnthagen
Copy link
Contributor Author

johnthagen commented May 25, 2023

Maybe we could temporarily put a upper bound on asgiref during testing?

Another option could be to remove PyPy from CI.

@johnthagen johnthagen marked this pull request as ready for review May 25, 2023 21:37
@johnthagen
Copy link
Contributor Author

@vinnyrose Thanks for tracking down the CI issue!

@johnthagen
Copy link
Contributor Author

@vinnyrose Your changes look good to me. Anything else needed to merged this PR? Thanks.

@vinnyrose
Copy link
Collaborator

@vinnyrose Your changes look good to me. Anything else needed to merged this PR? Thanks.

Thanks for the reminder, I meant to get to this in the last few days. Hope to have this in by the weekend.

@johnthagen
Copy link
Contributor Author

image

@vinnyrose vinnyrose changed the base branch from master to feature/8.0 June 13, 2023 23:05
@vinnyrose vinnyrose merged commit 2b223b3 into un1t:feature/8.0 Jun 13, 2023
@johnthagen johnthagen deleted the django-4.2 branch June 13, 2023 23:13
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants