From 141970540f57ce298041178cc4c82fbb02be20be Mon Sep 17 00:00:00 2001 From: Ayman Saleh Date: Wed, 10 Nov 2021 03:32:15 -0500 Subject: [PATCH 1/2] Fix to resource warning allocation; utilize file.open within a context manager --- utils/general.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/utils/general.py b/utils/general.py index a6fe603850c8..f4339bfaf45a 100755 --- a/utils/general.py +++ b/utils/general.py @@ -264,7 +264,8 @@ def check_requirements(requirements=ROOT / 'requirements.txt', exclude=(), insta if isinstance(requirements, (str, Path)): # requirements.txt file file = Path(requirements) assert file.exists(), f"{prefix} {file.resolve()} not found, check failed." - requirements = [f'{x.name}{x.specifier}' for x in pkg.parse_requirements(file.open()) if x.name not in exclude] + with file.open() as fh: + requirements = [f'{x.name}{x.specifier}' for x in pkg.parse_requirements(fh) if x.name not in exclude] else: # list or tuple of packages requirements = [x for x in requirements if x not in exclude] From 3a562c05c582d3943c98a14b1f45a03e7255a4ad Mon Sep 17 00:00:00 2001 From: Glenn Jocher Date: Wed, 10 Nov 2021 12:34:35 +0100 Subject: [PATCH 2/2] rename fh to f in keeping with naming convention --- utils/general.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/utils/general.py b/utils/general.py index f4339bfaf45a..8f59d487edfb 100755 --- a/utils/general.py +++ b/utils/general.py @@ -264,8 +264,8 @@ def check_requirements(requirements=ROOT / 'requirements.txt', exclude=(), insta if isinstance(requirements, (str, Path)): # requirements.txt file file = Path(requirements) assert file.exists(), f"{prefix} {file.resolve()} not found, check failed." - with file.open() as fh: - requirements = [f'{x.name}{x.specifier}' for x in pkg.parse_requirements(fh) if x.name not in exclude] + with file.open() as f: + requirements = [f'{x.name}{x.specifier}' for x in pkg.parse_requirements(f) if x.name not in exclude] else: # list or tuple of packages requirements = [x for x in requirements if x not in exclude]