Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to get NMS in TFJS exported model #11728

Closed
2 tasks done
Abhishekvats1997 opened this issue Jun 18, 2023 · 5 comments
Closed
2 tasks done

Unable to get NMS in TFJS exported model #11728

Abhishekvats1997 opened this issue Jun 18, 2023 · 5 comments
Labels
bug Something isn't working Stale

Comments

@Abhishekvats1997
Copy link

Abhishekvats1997 commented Jun 18, 2023

Search before asking

  • I have searched the YOLOv5 issues and found no similar bug report.

YOLOv5 Component

No response

Bug

I tried exporting my trained .pt model to tfjs. The --nms flag and --topk-per-class flags do not seem to have any effect on the exported model.

Environment

No response

Minimal Reproducible Example

No response

Additional

No response

Are you willing to submit a PR?

  • Yes I'd like to help by submitting a PR!
@Abhishekvats1997 Abhishekvats1997 added the bug Something isn't working label Jun 18, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 18, 2023

👋 Hello @Abhishekvats1997, thank you for your interest in YOLOv5 🚀! Please visit our ⭐️ Tutorials to get started, where you can find quickstart guides for simple tasks like Custom Data Training all the way to advanced concepts like Hyperparameter Evolution.

If this is a 🐛 Bug Report, please provide a minimum reproducible example to help us debug it.

If this is a custom training ❓ Question, please provide as much information as possible, including dataset image examples and training logs, and verify you are following our Tips for Best Training Results.

Requirements

Python>=3.7.0 with all requirements.txt installed including PyTorch>=1.7. To get started:

git clone https://github.com/ultralytics/yolov5  # clone
cd yolov5
pip install -r requirements.txt  # install

Environments

YOLOv5 may be run in any of the following up-to-date verified environments (with all dependencies including CUDA/CUDNN, Python and PyTorch preinstalled):

Status

YOLOv5 CI

If this badge is green, all YOLOv5 GitHub Actions Continuous Integration (CI) tests are currently passing. CI tests verify correct operation of YOLOv5 training, validation, inference, export and benchmarks on macOS, Windows, and Ubuntu every 24 hours and on every commit.

Introducing YOLOv8 🚀

We're excited to announce the launch of our latest state-of-the-art (SOTA) object detection model for 2023 - YOLOv8 🚀!

Designed to be fast, accurate, and easy to use, YOLOv8 is an ideal choice for a wide range of object detection, image segmentation and image classification tasks. With YOLOv8, you'll be able to quickly and accurately detect objects in real-time, streamline your workflows, and achieve new levels of accuracy in your projects.

Check out our YOLOv8 Docs for details and get started with:

pip install ultralytics

@glenn-jocher
Copy link
Member

@Abhishekvats1997 hi there!

Thank you for bringing this issue to our attention. I understand that you are experiencing trouble with the --nms and --topk-per-class flags not having any effect on the exported model when using YOLOv5 with TensorFlow.js.

To investigate this issue further, it would be helpful if you could provide a minimal reproducible example, including the steps to export the model and any relevant code snippets. This will allow us to better understand the problem and assist you with finding a solution.

Furthermore, if you are willing to submit a pull request to address this issue, we greatly appreciate your contribution! Our team will be more than happy to review and merge your changes. Please ensure that your proposed changes follow our contribution guidelines.

Thank you again for your report, and we look forward to working with you to address this issue.

@Abhishekvats1997
Copy link
Author

Code used to export
python export.py --weights ../shibumi/model.pt --topk-per-class 1 --include tfjs --nms
Expectation
A model which gives out 1 object per class with nms.

After a bit of digging I could see the reason for this as
https://github.com/ultralytics/yolov5/blob/2334aa733872bc4bb3e1a1ba90e5fd319399596f/export.py#LL787C78-L787C78

The "or" here is causing the model conversion to default to class-agnostic NMS in the case of tfjs. After trying to remove this condition I get errors highlighting that the CombinedNonMax Suppression layer is not implemented on TFJs. Is this the reason that you have introduced the above-mentioned "or" condition? If yes, can you suggest a possible solution to use yolov5 on tfjs with per class NMS and limit objects per class other than the manual for loops in JS :( .

@glenn-jocher
Copy link
Member

@Abhishekvats1997 hello!

Thank you for bringing this issue to our attention. I understand that you're experiencing difficulty with the --nms and --topk-per-class flags while exporting a YOLOv5 model to TensorFlow.js.

After further investigation, it appears that the "or" condition you noticed in the export script is indeed causing the model conversion to default to class-agnostic NMS in the case of TensorFlow.js. Unfortunately, the CombinedNonMax Suppression layer is not implemented in TensorFlow.js, which is why the condition is in place.

As of now, there is no straightforward solution to accomplish per-class NMS and limit the number of objects per class in TensorFlow.js without resorting to manual for loops in JavaScript. It would involve implementing custom JavaScript code for performing per-class NMS and enforcing the object limits.

We understand that this could lead to potential performance overhead due to the need for additional computation in JavaScript. If this functionality is critical for your use case, we recommend considering alternative options such as using Python or exploring other object detection frameworks that support per-class NMS and object limits in TensorFlow.js.

We hope this information clarifies the situation. Please let us know if you have any further questions or concerns. We appreciate your interest in YOLOv5 and the Ultralytics team's work.

Thank you for your understanding and contribution to the YOLO community!

@github-actions
Copy link
Contributor

👋 Hello there! We wanted to give you a friendly reminder that this issue has not had any recent activity and may be closed soon, but don't worry - you can always reopen it if needed. If you still have any questions or concerns, please feel free to let us know how we can help.

For additional resources and information, please see the links below:

Feel free to inform us of any other issues you discover or feature requests that come to mind in the future. Pull Requests (PRs) are also always welcomed!

Thank you for your contributions to YOLO 🚀 and Vision AI ⭐

@github-actions github-actions bot added the Stale label Jul 20, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Stale
Projects
None yet
Development

No branches or pull requests

2 participants