Skip to content
This repository has been archived by the owner on May 13, 2024. It is now read-only.

fix: generate pagination title correctly (fix: #41) #42

Merged
merged 2 commits into from
Dec 7, 2019

Conversation

billyyyyy3320
Copy link
Member

Summary

Plus 1 since index starts at 0.
Plus another 1 since the index page won't show page number.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@billyyyyy3320 billyyyyy3320 merged commit 586bf14 into master Dec 7, 2019
@billyyyyy3320 billyyyyy3320 deleted the fix/pagination_title branch January 9, 2020 15:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant