-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade angular hybrid from 7.0.0 to latest (10) Angular states no longer registering #437
Comments
If I add console.log's the router modules are being loaded before the sync, if i add the route directly inside the app.module, it still doesn't exist |
Trying to debug it. Seems like when it hits t his piece of code, which it only hits once the modules is an empty array
Same for this piece of code that also only passes by once, states is undefined resulting in an empty [] due to the || statement
|
Ok it seems that in the function above, the |
Ok seen that the |
@SamanthaAdrichem Looked into this further as we have the same issue. It wasn't the moving to a separate file that broke it but that it is no longer exported from index.ts |
I figured as much, but during local debugging inside node_modules, including it didn't fix it so I wasn't sure. |
Did you ever resolve this problem and were you able to upgrade? @SamanthaAdrichem |
Nope, never had the time, otherwise i would’ve made a PR. I think your new PR fixes it. |
This issue has been automatically marked as stale because it has not had |
We've been using angular-hybrid from a while and today we've upgraded to Angular 9.0.7 (wanted to go to 9.1.9, but there are issues with the compiler on windows).
We've always written our states in separate module files with each page.
Now since upgrading uirouter, which was at 7.0.0 to the following
our bootstrap is still as such
The routes inside angular are no longer being loaded. All AngularJS routes still work and exist.
Can't seem to find a change listed to explain this.
Anyone got any clue what changed?
The text was updated successfully, but these errors were encountered: