Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extremely verbose write statement in FV3 #2209

Closed
SamuelTrahanNOAA opened this issue Mar 27, 2024 · 3 comments · Fixed by #2201
Closed

extremely verbose write statement in FV3 #2209

SamuelTrahanNOAA opened this issue Mar 27, 2024 · 3 comments · Fixed by #2201
Labels
bug Something isn't working

Comments

@SamuelTrahanNOAA
Copy link
Collaborator

Description

This write statement produces many megabytes of output for some configurations. It is enough to have a significant impact on the runtime:

write(0,*) ' history_type_store_data3D kinds ', kind_phys, kind(work), lbound(work), ubound(work), size(work)

To Reproduce:

Run FV3 with the write component. Witness the write statement

@DusanJovic-NOAA
Copy link
Collaborator

@SamuelTrahanNOAA
Copy link
Collaborator Author

That PR is still a draft.

Our fix is identical (delete the line) so it doesn't matter which one is merged first.

@SamuelTrahanNOAA
Copy link
Collaborator Author

This was actually fixed in an earlier pull request, not 2201. Probably the pull request Dusan points to, two messages ago (NOAA-EMC/fv3atm#803) but I can't be certain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants