Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some conus13km tests incorrectly specify the control as a task dependency. #1921

Closed
SamuelTrahanNOAA opened this issue Sep 25, 2023 · 0 comments · Fixed by #1893
Closed

Some conus13km tests incorrectly specify the control as a task dependency. #1921

SamuelTrahanNOAA opened this issue Sep 25, 2023 · 0 comments · Fixed by #1893
Labels
bug Something isn't working

Comments

@SamuelTrahanNOAA
Copy link
Collaborator

Description

There are errors like this in the rt.conf:

RUN | conus13km_control                                 | + hera cheyenne hercules            | baseline |
RUN | conus13km_2threads                                | + hera cheyenne hercules            |          | conus13km_control
RUN | conus13km_restart_mismatch                        | + hera cheyenne hercules            | baseline | conus13km_control

The last column is the task dependency. In these rows, that dependency is "conus13km_control."

In this example, the conus13km_2threads row (second row) is wrong. It has a dependency on conus13km_control. It doesn't need that dependency because those two jobs can run at the same time. The conus13km_restart_mismatch (second row) has the same dependency. That job does need a dependency, because the restart jobs read files from the control run (first row).

Only the conus13km restart runs need task dependencies.

To Reproduce:

Look at rt.conf, OR run rt.sh and notice the incorrect dependency.

Additional context

I noticed this while testing #1917 and #1893. I'm not comfortable changing rt.conf in those PRs at this late stage of testing. However, I'll have another PR in a few days to reduce CLM Lake restart file sizes. That PR will include a fix for this, if nobody else fixes it first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment