Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rte-rrtmgp dtc/ccpp is out-of-date, and must be updated to work with kind_phys=4 #1300

Open
SamuelTrahanNOAA opened this issue Jun 29, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@SamuelTrahanNOAA
Copy link
Collaborator

SamuelTrahanNOAA commented Jun 29, 2022

Description

The rte-rrtmgp submodule (dtc/ccpp branch) is out-of-date. Although it will compile with kind_phys=4, it won't work properly. There is a proposed solution, but as of this writing, it hasn't been implemented yet. Code manager @RobertPincus pointed this out when merging earth-system-radiation/rte-rrtmgp#180. See another note from him in the comments.

Edit: The main branch doesn't have the changes needed for single precision support either, as noted below in #RobertPincus's comment.

To Reproduce:

  1. Compare main to dtc/ccpp
  2. Read issues discussing the necessity of several changes to the kernel to support 32-bit floating-point.
  3. Notice those changes aren't in dtc/ccpp
@SamuelTrahanNOAA SamuelTrahanNOAA added the bug Something isn't working label Jun 29, 2022
@RobertPincus
Copy link

@SamuelTrahanNOAA Note that the main branch does not yet run in single precision either. This is the next major task but likely won't happen until August.

@SamuelTrahanNOAA
Copy link
Collaborator Author

@SamuelTrahanNOAA Note that the main branch does not yet run in single precision either. This is the next major task but likely won't happen until August.

I have updated the description to match this information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants