Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: different module output.name #248

Closed
wants to merge 1 commit into from

Conversation

iliyaZelenko
Copy link
Contributor

Hi, you did a good package, great job!

At the moment I am developing my package based on yours. But I had a little problem.

I make a package that uses tiptap and tiptap-extensions packages. But these two packages are written in one variable - tiptap.

In my rollup config in output -> globals I have to specify two different names, not

globals: {
  'tiptap': 'tiptap',
  'tiptap-extensions': 'tiptap'
}

Would be right:

globals: {
  'tiptap': 'tiptap',
  'tiptap-extensions': 'tiptapExtensions'
}

My PR removes the problem with the name (variables) conflict when you use the UMD module as IIFE.

the ability to have a different module variable name (output.name)
@iliyaZelenko
Copy link
Contributor Author

To be honest, I did not understand the reason for the error CI. Is my code exactly to blame?

@philippkuehn
Copy link
Contributor

there was an issue with your PR. this should be fixed in d0fc404

@iliyaZelenko iliyaZelenko deleted the patch-4 branch June 15, 2019 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants