Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add random_state to upliftTreeClassifier and upliftRandomForestClassifier #401

Closed
flippercy opened this issue Oct 13, 2021 · 3 comments
Closed
Assignees
Labels
enhancement New feature or request

Comments

@flippercy
Copy link

So far the prediction of upliftTreeClassifier and upliftRandomForestClassifier is not repeatable, which is probably due to the missing of random_state. Could someone add this as a parameter, please?

Thank you.

@flippercy flippercy added the enhancement New feature or request label Oct 13, 2021
@paullo0106 paullo0106 self-assigned this Oct 13, 2021
@paullo0106
Copy link
Collaborator

You're right, thanks for bringing this up. It's currently not a reproducible result for the UpliftTree, #275 was a previous attempt by @RuslanTs to address the issue, as a reference

@manojbalaji1
Copy link
Contributor

manojbalaji1 commented Nov 15, 2021

@paullo0106 I think we need to use randomstate rather than np.random.seed(42). I think there's this issue raised that np.random.seed is not thread-safe. I think that should be the issue. Let me investigate this problem and try to fix it

Reference: https://stackoverflow.com/questions/7029993/differences-between-numpy-random-and-random-random-in-python#:~:text=For%20numpy.random,to%20the%20contrary).

@jeongyoonlee
Copy link
Collaborator

Added in #422.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants