From 3ce4d9f75d29f34b7392f0e08e090c6a3fb3121e Mon Sep 17 00:00:00 2001 From: Aaron Abramov Date: Sat, 22 Jul 2017 01:39:01 -0700 Subject: [PATCH] Don't print test summary in --silent (#4106) --- .../__snapshots__/console.test.js.snap | 1 - integration_tests/utils.js | 2 +- .../src/reporters/summary_reporter.js | 20 ++++++++++--------- 3 files changed, 12 insertions(+), 11 deletions(-) diff --git a/integration_tests/__tests__/__snapshots__/console.test.js.snap b/integration_tests/__tests__/__snapshots__/console.test.js.snap index 7215dd4217bb..ec173b3fb720 100644 --- a/integration_tests/__tests__/__snapshots__/console.test.js.snap +++ b/integration_tests/__tests__/__snapshots__/console.test.js.snap @@ -71,6 +71,5 @@ exports[`does not print to console with --silent 3`] = ` Tests: 1 passed, 1 total Snapshots: 0 total Time: <> -Ran all test suites. " `; diff --git a/integration_tests/utils.js b/integration_tests/utils.js index 526f2d705988..206fd52a780d 100644 --- a/integration_tests/utils.js +++ b/integration_tests/utils.js @@ -120,7 +120,7 @@ const createEmptyPackage = (directory, packageJson) => { const extractSummary = stdout => { const match = stdout.match( - /Test Suites:.*\nTests.*\nSnapshots.*\nTime.*\nRan all test suites.*\n*$/gm, + /Test Suites:.*\nTests.*\nSnapshots.*\nTime.*(\nRan all test suites)*.*\n*$/gm, ); if (!match) { throw new Error( diff --git a/packages/jest-cli/src/reporters/summary_reporter.js b/packages/jest-cli/src/reporters/summary_reporter.js index aec76df3a0ad..8d1a0afcfe9b 100644 --- a/packages/jest-cli/src/reporters/summary_reporter.js +++ b/packages/jest-cli/src/reporters/summary_reporter.js @@ -106,16 +106,18 @@ class SummaryReporter extends BaseReporter { ); if (numTotalTestSuites) { - const testSummary = wasInterrupted - ? chalk.bold.red('Test run was interrupted.') - : this._getTestSummary(contexts, this._globalConfig); - this.log( - getSummary(aggregatedResults, { - estimatedTime: this._estimatedTime, - }) + + let message = getSummary(aggregatedResults, { + estimatedTime: this._estimatedTime, + }); + + if (!this._globalConfig.silent) { + message += '\n' + - testSummary, - ); + (wasInterrupted + ? chalk.bold.red('Test run was interrupted.') + : this._getTestSummary(contexts, this._globalConfig)); + } + this.log(message); } } }