-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Custom Script Engine #185
Merged
tmspzz
merged 44 commits into
tmspzz:master
from
BalestraPatrick:feature/engines-complete
May 18, 2019
Merged
Add Custom Script Engine #185
tmspzz
merged 44 commits into
tmspzz:master
from
BalestraPatrick:feature/engines-complete
May 18, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hlintBot
reviewed
May 16, 2019
hlintBot
reviewed
May 16, 2019
Repository owner
deleted a comment from
hlintBot
May 17, 2019
hlintBot
reviewed
May 17, 2019
Repository owner
deleted a comment from
hlintBot
May 17, 2019
Repository owner
deleted a comment from
hlintBot
May 18, 2019
tmspzz
reviewed
May 18, 2019
tmspzz
reviewed
May 18, 2019
Co-Authored-By: Tommaso Piazza <196761+blender@users.noreply.github.com>
tmspzz
approved these changes
May 18, 2019
Repository owner
deleted a comment from
hlintBot
May 18, 2019
PR looks good to me! |
@blender Could you release this to CocoaPods? |
Sure! @thii there is a pre-release version attached to the releases. Did you have a chance to try it? |
I've tried it and found no problems so far. |
@thii it's out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I continued working on #148 and fixed the conflicts with master that arose from the latest release, so I am creating a new PR for an easier review directly with master. Let me know if you prefer otherwise and I have another branch that doesn't have the conflicts fixed yet, so I could make a PR to
feature/engines
first and then to master. 👍I did some extensive testing by even prototyping a simple NodeJS server and a script that does the communication part taking in
list
,upload
anddownload
commands and it's working as expected.I also threw in some random typos and documentation fixes noticed in reading the existing code.
I didn't run Brittany yet, so I am sure there will be a ton of fixes done to my bad Haskell 😄
Regarding integration tests, I wrote
engine.sh
that quickly simulates an engine that simply stores the artifacts in a local folder. Added a bunch of integration tests covering all cases:current-framework-engine-yml.bats
current-framework-named-engine-yml.bats
dynamic-frameworks-engine-yml.bats
static-frameworks-engine-yml.bats
I also renamed
current-framework-yaml.bats
tocurrent-framework-yml.bats
andcurrent-framework-named-yaml.bats
tocurrent-framework-named-yml.bats
for consistency.Fixes #146