Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rome does not recognize last entry in Cartfile.resolved if there's no new line at end #165

Closed
jbuckner opened this issue Feb 13, 2019 · 4 comments
Labels

Comments

@jbuckner
Copy link

jbuckner commented Feb 13, 2019

Enhancement Suggestion / Bug Report

If there's no new line at the end of the last entry of Cartfile.resolved, Rome does not detect it as a dependency and doesn't upload or download it.

Steps which explain the enhancement or reproduce the bug

  1. Remove any new line characters from the end of Cartfile.resolved so it ends at the last character of the last entry.
  2. Run rome upload or rome download

Current behavior

Rome does not recognize the last entry in Cartfile.resolved and doesn't upload or download it. It doesn't throw any errors, just silently skips it.

Suggested behavior

Rome should recognize this last dependency

Why would the enhancement be useful to most users

This failure is silent and there's no indication that it has failed unless you look through the upload/download logs for the missing dependency.

Rome version:

`0.18.1.53`

OS and version:

Mac OS 10.14
@tmspzz tmspzz added the bug label Feb 13, 2019
@tmspzz
Copy link
Owner

tmspzz commented Feb 13, 2019

Thanks for reporting, I will investigate.

Edit:

so here we're talking about a missing https://www.fileformat.info/info/unicode/char/000a/index.htm or missing http://www.fileformat.info/info/unicode/char/000d/index.htm at the end of last line

@tmspzz
Copy link
Owner

tmspzz commented Feb 13, 2019

@jbuckner Please try: https://github.com/blender/Rome/releases/tag/v0.18.2.54 and let me know if it solves your issue.

This is a high risk change since I had to almost completely redo the parsing of the Cartfile.resolved

@jbuckner
Copy link
Author

jbuckner commented Feb 13, 2019

@blender Thank you for jumping on this so quickly! I tested 0.18.2.54 and it fixes the issue!

@tmspzz
Copy link
Owner

tmspzz commented Feb 16, 2019

@jbuckner released in https://github.com/blender/Rome/releases/tag/v0.19.0.55

I bumped the version number because of the new parser.

Are you using this project privately or for work?
If you use it for work would you mind if I add your employer to the list of Rome users?

@tmspzz tmspzz closed this as completed Feb 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants