From b289638de1cbdaaed53bf8f78c90bd69fb1e6b9c Mon Sep 17 00:00:00 2001 From: Spencer Miskoviak <5247455+skovy@users.noreply.github.com> Date: Wed, 18 Nov 2020 11:38:29 -0800 Subject: [PATCH] fix(prefer-explicit-assert): handle valid getBy* without expect (#257) --- lib/rules/prefer-explicit-assert.ts | 1 + tests/lib/rules/prefer-explicit-assert.test.ts | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/rules/prefer-explicit-assert.ts b/lib/rules/prefer-explicit-assert.ts index fb634603..bb9f6614 100644 --- a/lib/rules/prefer-explicit-assert.ts +++ b/lib/rules/prefer-explicit-assert.ts @@ -95,6 +95,7 @@ export default ESLintUtils.RuleCreator(getDocsUrl)({ }); } else if (assertion) { const expectCallNode = findClosestCallNode(node, 'expect'); + if (!expectCallNode) return; const expectStatement = expectCallNode.parent as TSESTree.MemberExpression; const property = expectStatement.property as TSESTree.Identifier; diff --git a/tests/lib/rules/prefer-explicit-assert.test.ts b/tests/lib/rules/prefer-explicit-assert.test.ts index b838ade3..0ebef887 100644 --- a/tests/lib/rules/prefer-explicit-assert.test.ts +++ b/tests/lib/rules/prefer-explicit-assert.test.ts @@ -67,7 +67,9 @@ ruleTester.run(RULE_NAME, rule, { code: `queryByText("foo")`, }, { - code: `expect(getByText('foo')).toBeTruthy()`, + code: `expect(getByText('foo')).toBeTruthy() + + fireEvent.click(getByText('bar'));`, options: [ { assertion: 'toBeTruthy',