Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow optional creation of S3 endpoint association for database subnets #607

Closed
grozdz opened this issue Mar 3, 2021 · 1 comment · Fixed by #635
Closed

Allow optional creation of S3 endpoint association for database subnets #607

grozdz opened this issue Mar 3, 2021 · 1 comment · Fixed by #635

Comments

@grozdz
Copy link

grozdz commented Mar 3, 2021

Currenly, VPC module allows to create S3 endpoint for private and public subnets (optionally). It would be great to add possibility to create such endpoint (route table association) for database subnets as well. This could be very useful for enabling S3 access from RDS via S3 endpoint like described here: https://docs.aws.amazon.com/AmazonRDS/latest/AuroraUserGuide/AuroraMySQL.Integrating.SaveIntoS3.html
and there:
https://docs.aws.amazon.com/AmazonRDS/latest/AuroraUserGuide/AuroraMySQL.Integrating.Authorizing.Network.html

I think it could be done by simple code like:

  count = var.create_vpc && var.enable_s3_endpoint && var.enable_database_s3_endpoint && length(var.database_subnets) > 0 && var.s3_endpoint_type == "Gateway" ? local.nat_gateway_count : 0

  vpc_endpoint_id = aws_vpc_endpoint.s3[0].id
  route_table_id  = element(aws_route_table.database.*.id, count.index)
}

in vpc-endpoints.tf.

BR
Grzegorz

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
1 participant