"default_vpc" documentation may be misleading

[Gurulhu]

This is quite a minor issue but I must admit I got fooled by it: If you create a new VPC in a region that already have a default VPC, the default_vpc_id won't be the same as vpc_id. Same goes for cidr_block and other attributes.

This is kinda obvious, but the documentation (and the outputs.tf) right now implies that these values are the same.

Since this is a minor issue, I'm forking it already to submit a PR and this issue is just to correlate in the PR.

Affected outputs:
| default_vpc_arn | The ARN of the VPC |
| default_vpc_cidr_block | The CIDR block of the VPC |
| default_vpc_default_network_acl_id | The ID of the default network ACL |
| default_vpc_default_route_table_id | The ID of the default route table |
| default_vpc_default_security_group_id | The ID of the security group created by default on VPC creation |
| default_vpc_enable_dns_hostnames | Whether or not the VPC has DNS hostname support |
| default_vpc_enable_dns_support | Whether or not the VPC has DNS support |
| default_vpc_id | The ID of the VPC |
| default_vpc_instance_tenancy | Tenancy of instances spin up within VPC |
| default_vpc_main_route_table_id | The ID of the main route table associated with this VPC |

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.