Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added create_before_destroy to aws_customer_gateway #1036

Merged
merged 2 commits into from
Feb 9, 2024
Merged

Conversation

cageyv
Copy link
Contributor

@cageyv cageyv commented Jan 26, 2024

Description

In case of customer_gateway is used with TGW this changes will allow us to replace ip_address in the single terraform apply

Motivation and Context

│ Error: deleting EC2 Customer Gateway (cgw-xxxxxxxxx): IncorrectState: The customer gateway is in use.
│       status code: 400, request id: xxxxxx-994b-xxxx-xxx-xxxxxx

Breaking Changes

No

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

Was tested on production system

@cageyv cageyv changed the title feat: aws_customer_gateway: create_before_destroy = true feat: Fix aws_customer_gateway: create_before_destroy = true Jan 26, 2024
@cageyv cageyv marked this pull request as ready for review January 26, 2024 07:17
main.tf Outdated Show resolved Hide resolved
@antonbabenko antonbabenko changed the title feat: Fix aws_customer_gateway: create_before_destroy = true fix: Added create_before_destroy to aws_customer_gateway Feb 9, 2024
@antonbabenko antonbabenko merged commit 5f5df57 into terraform-aws-modules:master Feb 9, 2024
20 checks passed
antonbabenko pushed a commit that referenced this pull request Feb 9, 2024
### [5.5.2](v5.5.1...v5.5.2) (2024-02-09)

### Bug Fixes

* Added create_before_destroy to aws_customer_gateway ([#1036](#1036)) ([5f5df57](5f5df57))
@antonbabenko
Copy link
Member

This PR is included in version 5.5.2 🎉

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants