Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace app_dirs crate? #93

Closed
dbrgn opened this issue Nov 27, 2019 · 1 comment
Closed

Replace app_dirs crate? #93

dbrgn opened this issue Nov 27, 2019 · 1 comment
Labels
chore

Comments

@dbrgn
Copy link
Collaborator

dbrgn commented Nov 27, 2019

The app_dirs crate has a negative crev review:

cargo crev repo query review app_dirs
---
kind: package review
version: -1
date: "2019-01-06T15:49:21.839825922-08:00"
from:
  id-type: crev
  id: FYlr8YoYGVvDwHQxqEIs89reKKDy-oWisoO0qXXEfHE
  url: "https://github.com/dpc/crev-proofs"
package:
  source: "https://crates.io"
  name: app_dirs
  version: 1.2.1
  digest: mWo2YhBk4cw2sAuMAtQQukncheMihw0EDklVz6nqQGs
review:
  thoroughness: none
  understanding: none
  rating: negative
comment: |-
  It looks like it's not maintained, and they are problems with it. See https://github.com/dpc/crev/pull/133

In crev-dev/cargo-crev#133 they migrated to the directories crate. Maybe tealdeer should do this too.
@dbrgn dbrgn added the chore label Nov 27, 2019
@dbrgn dbrgn mentioned this issue Aug 30, 2020
Merged
@dbrgn
Copy link
Collaborator Author

dbrgn commented Aug 30, 2020

Fixed in #124.

@dbrgn dbrgn closed this as completed Aug 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dbrgn