From 5d2b9ca27b12ceea453ef3f095e57810dbd2a722 Mon Sep 17 00:00:00 2001 From: Emmanuel Ogbizi-Ugbe Date: Thu, 12 Nov 2020 21:23:41 -0500 Subject: [PATCH] chore: include file extension in max filename len --- src/syrupy/extensions/single_file.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/syrupy/extensions/single_file.py b/src/syrupy/extensions/single_file.py index b637e420..6e524059 100644 --- a/src/syrupy/extensions/single_file.py +++ b/src/syrupy/extensions/single_file.py @@ -69,6 +69,7 @@ def _write_snapshot_fossil(self, *, snapshot_fossil: "SnapshotFossil") -> None: def __clean_filename(self, filename: str) -> str: filename = str(filename).strip().replace(" ", "_") + max_filename_length = 255 - len(self._file_extension or "") exclude_chars = '\\/?%*:|"<>,;=' exclude_categ = ("C",) cleaned_filename = "".join( @@ -77,4 +78,4 @@ def __clean_filename(self, filename: str) -> str: if c not in exclude_chars and not any(categ in category(c) for categ in exclude_categ) ) - return cleaned_filename[:255] # maximum filename length + return cleaned_filename[:max_filename_length]