From e8a4e170ee4c57b01a26db1df837c18469af866d Mon Sep 17 00:00:00 2001 From: ChiTimesChi <88190723+ChiTimesChi@users.noreply.github.com> Date: Wed, 9 Oct 2024 15:08:28 +0100 Subject: [PATCH 1/3] ci: skip Slither/GasDiff/SizeCheck for single solidity-devops as well --- .github/workflows/solidity.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/solidity.yml b/.github/workflows/solidity.yml index 19d0d643a1..9e8c807f31 100644 --- a/.github/workflows/solidity.yml +++ b/.github/workflows/solidity.yml @@ -121,7 +121,7 @@ jobs: cancel_others: 'true' slither: name: Slither - if: ${{ needs.changes.outputs.package_count > 0 }} + if: ${{ needs.changes.outputs.package_count > 0 && needs.changes.outputs.packages != '["solidity-devops"]' }} # see https://docs.github.com/en/code-security/code-scanning/automatically-scanning-your-code-for-vulnerabilities-and-errors/setting-up-code-scanning-for-a-repository runs-on: ubuntu-latest needs: changes @@ -239,7 +239,7 @@ jobs: gas-diff: runs-on: ubuntu-latest name: Foundry Gas Diff - if: ${{ needs.changes.outputs.package_count > 0 }} + if: ${{ needs.changes.outputs.package_count > 0 && needs.changes.outputs.packages != '["solidity-devops"]' }} needs: changes strategy: fail-fast: false @@ -290,7 +290,7 @@ jobs: size-check: name: Foundry Size Check runs-on: ubuntu-latest - if: ${{ needs.changes.outputs.package_count > 0 }} + if: ${{ needs.changes.outputs.package_count > 0 && needs.changes.outputs.packages != '["solidity-devops"]' }} needs: changes strategy: fail-fast: false From 9ad00bec9f1de5318f8b1fe94a30a9b7f38acce6 Mon Sep 17 00:00:00 2001 From: ChiTimesChi <88190723+ChiTimesChi@users.noreply.github.com> Date: Wed, 9 Oct 2024 15:09:12 +0100 Subject: [PATCH 2/3] add temporary change to trigger workflows --- packages/solidity-devops/src/SynapseScript.sol | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/solidity-devops/src/SynapseScript.sol b/packages/solidity-devops/src/SynapseScript.sol index 705410ace8..d182d67c0a 100644 --- a/packages/solidity-devops/src/SynapseScript.sol +++ b/packages/solidity-devops/src/SynapseScript.sol @@ -9,6 +9,7 @@ import {SynapseBaseScript} from "./base/SynapseBaseScript.sol"; import {StringUtils} from "./libs/StringUtils.sol"; import {stdJson} from "forge-std/Script.sol"; +// TODO: remove this temp comment abstract contract SynapseScript is SynapseBaseScript { /// @notice Should return "💬" function getInfoEmoji() internal pure virtual override returns (string memory) { From f75ee1e98e046a2bdef1bee154c3a6e52adbc88a Mon Sep 17 00:00:00 2001 From: ChiTimesChi <88190723+ChiTimesChi@users.noreply.github.com> Date: Wed, 9 Oct 2024 15:11:13 +0100 Subject: [PATCH 3/3] Revert "add temporary change to trigger workflows" This reverts commit 9ad00bec9f1de5318f8b1fe94a30a9b7f38acce6. --- packages/solidity-devops/src/SynapseScript.sol | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/solidity-devops/src/SynapseScript.sol b/packages/solidity-devops/src/SynapseScript.sol index d182d67c0a..705410ace8 100644 --- a/packages/solidity-devops/src/SynapseScript.sol +++ b/packages/solidity-devops/src/SynapseScript.sol @@ -9,7 +9,6 @@ import {SynapseBaseScript} from "./base/SynapseBaseScript.sol"; import {StringUtils} from "./libs/StringUtils.sol"; import {stdJson} from "forge-std/Script.sol"; -// TODO: remove this temp comment abstract contract SynapseScript is SynapseBaseScript { /// @notice Should return "💬" function getInfoEmoji() internal pure virtual override returns (string memory) {