Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Next line after comment would not be formatted #152

Merged
merged 9 commits into from
Oct 10, 2020
Merged

Next line after comment would not be formatted #152

merged 9 commits into from
Oct 10, 2020

Conversation

ehrencrona
Copy link
Contributor

Fixes #151. There were two bugs here:

  • every comment was treated as a prettier-ignore-next attribute
  • the detection of whether the next node was an embedded node that had been removed from the AST did not work when the comment was the last child node

@ehrencrona ehrencrona changed the title Lines after comments ignored Next line after comment would not be formatted Oct 9, 2020
@dummdidumm
Copy link
Member

Could you resolve the conflicts? After that I'll merge 👍

@ehrencrona
Copy link
Contributor Author

Conflicts resolved!

@dummdidumm dummdidumm merged commit e748b58 into sveltejs:master Oct 10, 2020
@dummdidumm dummdidumm mentioned this pull request Oct 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dummdidumm dummdidumm dummdidumm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HTML comments inside svelte markup cause formatting to fail
2 participants
@ehrencrona @dummdidumm