Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"float" is changed to "cssFloat" after formating #146

Closed
guoyunhe opened this issue Oct 16, 2020 · 1 comment
Closed

"float" is changed to "cssFloat" after formating #146

guoyunhe opened this issue Oct 16, 2020 · 1 comment
Labels
upstream relates to an upstream package

Comments

@guoyunhe
Copy link

Clearly describe the bug

I have CSS-In-JS project with material-ui and React. Stylelint always format float property into cssFloat, however this breaks the code...

What code is needed to reproduce this issue?

import { makeStyles, Theme } from '@material-ui/core/styles';

const useStyles = makeStyles((theme: Theme) => ({
  status: {
    borderRadius: theme.spacing(1),
    color: '#ffffff',
    float: 'right',
    padding: theme.spacing(1),
    width: 150,
    textAlign: 'center',
  },
  statusDraft: {
    background: '#707070',
  },
  statusPublished: {
    background: '#1c996f',
  },
}));

What vscode-stylelint configuration is needed to reproduce the bug?
I think I just have the default options with formatOnSave enabled.

Is this issue related to autofix? (editor.codeActionsOnSave)

Yes

Which version of vscode-stylelint are you using?

0.85.0

Which version of stylelint are you using?

No stylelint node module installed in the project.

Does your issue relate to non-standard syntax (e.g. SCSS, nesting, etc.)?

CSS in JS

What did you expect to happen?

It should not format float property.

What actually happened (e.g. what warnings or errors you are getting)?

It formats float into cssFloat, which doesn't work in browser.

@guoyunhe
Copy link
Author

See stylelint/stylelint#4490

@adalinesimonian adalinesimonian added the upstream relates to an upstream package label Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream relates to an upstream package
Projects
None yet
Development

No branches or pull requests

2 participants