You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
DoctorJohn
changed the title
We currently don't handle AIOHTTP websocket messages of type "ERROR"
AIOHTTP websocket messages of type "ERROR" not handled correctly
Sep 18, 2024
AIOHTTP closes the WebSocket internally with code 1006 (Abnormal Closure) before yielding a message of type "ERROR." Our WebSocket integration code recognizes that the WebSocket has been closed and gracefully stops. Before said PR was merged, our AIOHTTP integration would try to close the WebSocket again because a non-text message (i.e., the message of type "ERROR") was received.
Describe the Bug
Both our AIOHTTP implementations of the WS subprotocols currently don't handle AIOHTTP WS messages of type "ERROR" correctly:
Instead, both implementations should return an error to the client and close the connection.
Upvote & Fund
The text was updated successfully, but these errors were encountered: