Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django AsyncGraphQLView param: subscriptions_enabled misleading #2051

Closed
nrbnlulu opened this issue Jul 28, 2022 · 1 comment · Fixed by #3660
Closed

Django AsyncGraphQLView param: subscriptions_enabled misleading #2051

nrbnlulu opened this issue Jul 28, 2022 · 1 comment · Fixed by #3660

Comments

@nrbnlulu
Copy link
Member

nrbnlulu commented Jul 28, 2022

The docs about subscriptions_enabled are misleading.

the docs says:

subscriptions_enabled: optional boolean parameter enabling subscriptions in the GraphiQL interface, defaults to False.

I as a new user couldn't understand that It is just some hack to satisfy GraphiQL and not at all supporting websockets...
especially because Django can handle only HTTP requests and not websockets.

I realized that only after digging threw the source code and #726 , #1215 , #344.

I would remove that and I think what @patrick91 suggested in #726 :

Or we should tell people to use the ASGI view even for non websockets GraphQL :)

Is a better solution.

Upvote & Fund

  • We're using Polar.sh so you can upvote and help fund this issue.
  • We receive the funding once the issue is completed & confirmed by you.
  • Thank you in advance for helping prioritize & fund our backlog.
Fund with Polar
@patrick91
Copy link
Member

yes, we should change that 😊 feel free to make a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants