BUG: User profile always shows subscription delay

[dparker1005]

Users with a level using a subscription delay will always have that delay on their users page, even if there wasn't a delay on the level when they checked out. This can cause their users page to show incorrect information.

Steps to recreate:

1. Create level without subscription delay
2. Check out with user
3. Change level to have subscription delay (I have only tested with 'Y1-7-1')
4. View the user's profile on the WordPress backend. See that it says that the payment should renew on x date, where x is consistent with the subscription delay; however, this is not necessarily true since they checked out before the change

[MaryOJob]

Similar issue.
Steps to take:

1. Checkout for a free level without a subscription delay set
2. Add subscription delay (example 14 days) to this level, save
3. Refresh the test user's account page from step 1 and this displays, Free. after your 14 days trial, despite they checking out before the delay was set

This can be confusing to members on that level.

Moderators Only: #497588

[MaryOJob]

A workaround, for now, could be to make use of our Custom Level Text Add-On (https://www.paidmembershipspro.com/add-ons/pmpro-custom-level-cost-text/) to add preferred wording to be displayed to both old and new members on this level. Examples;